New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebhookParser class requires significant improvement #90

Open

IanKemp opened this issue Sep 23, 2022 · 0 comments

IanKemp commented Sep 23, 2022

It is incomplete because it does not allow callers to obtain the metadata embedded in the webhook (in particular the webhook ID).
It conflates the responsibilities of parsing and signature validation - I should be able to parse a webhook without validating its signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment