Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reentrant &mut self calls breaks hello world example #24

Closed
daniellavoie opened this issue Jan 8, 2024 · 5 comments
Closed

Reentrant &mut self calls breaks hello world example #24

daniellavoie opened this issue Jan 8, 2024 · 5 comments
Labels
question Further information is requested

Comments

@daniellavoie
Copy link

I am under the impression that godot-rust/gdext#501 broke the Hello World example.

I am getting the following compilation error:

error[E0599]: no method named `rotate` found for struct `godot::prelude::Base` in the current scope
  --> src/godot/mod.rs:30:19
   |
30 |       self.sprite.rotate((self.angular_speed * delta) as f32);
   |                   ^^^^^^ method not found in `Base<Sprite2D>`

I'll submit a PR to the doc if I get through a solution.

@daniellavoie daniellavoie changed the title Res Reentrant &mut self calls breaks hello world example Jan 8, 2024
@PgBiel
Copy link

PgBiel commented Jan 8, 2024

Sounds like this will be fixed by #21

@daniellavoie
Copy link
Author

Yes indeed ! Closing the issue. Thanks for pointing out

@PgBiel
Copy link

PgBiel commented Jan 8, 2024

I believe it should be fine to keep the issue open (at least IMO), since technically the problem is still there, at least until the PR is merged.

@Bromeon
Copy link
Member

Bromeon commented Jan 8, 2024

I'll merge the PR today.

@Bromeon
Copy link
Member

Bromeon commented Jan 8, 2024

PR is merged.

@Bromeon Bromeon added the question Further information is requested label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants