Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails in macos due to failed to resolve: could not find open_xr_action in engine #474

Closed
kuruk-mm opened this issue Nov 10, 2023 · 4 comments · Fixed by #475
Closed
Labels
bug c: engine Godot classes (nodes, resources, ...)

Comments

@kuruk-mm
Copy link
Contributor

kuruk-mm commented Nov 10, 2023

I updated from 4.1.1 to 4.1.3, and gdext from 00ba8c9d to 02f4acf5 and I started getting the following error in MacOS (Windows and Linux are OK):

error[E0433]: failed to resolve: could not find `open_xr_action` in `engine`
  --> /Users/mateomiccino/.cargo/git/checkouts/gdext-76630c89719e160c/02f4acf/godot-core/src/gen/classes/open_xr_interaction_profile_metadata.rs:88:223
   |
88 | ...dotString, action_type: crate::engine::open_xr_action::ActionType,) {
   |                                           ^^^^^^^^^^^^^^ could not find `open_xr_action` in `engine`

error[E0433]: failed to resolve: could not find `open_xr_action` in `engine`
  --> /Users/mateomiccino/.cargo/git/checkouts/gdext-76630c89719e160c/02f4acf/godot-core/src/gen/classes/open_xr_interaction_profile_metadata.rs:90:113
   |
90 |             type CallSig = ((), GodotString, GodotString, GodotString, GodotString, GodotString, crate::engine::open_xr_action::ActionType);
   |                                                                                                                 ^^^^^^^^^^^^^^ could not find `open_xr_action` in `engine`

I compared the generated files (at .cargo/git/checkouts/gdext-76630c89719e160c/02f4acf/godot-core/src/gen/classes) between Linux and Mac, and Mac is not generating the open_xr_** files, it just generating the open_xr_interaction_profile_metadata.

More details in a GH Action:
https://github.com/decentraland/godot-explorer/actions/runs/6824669204/job/18561040610

I'm using pre-build

[patch."https://github.com/godot-rust/godot4-prebuilt".godot4-prebuilt]
git = "https://github.com//godot-rust/godot4-prebuilt"
branch = "4.1.3"

entire cargo.toml: https://github.com/decentraland/godot-explorer/blob/main/rust/decentraland-godot-lib/Cargo.toml

@Bromeon
Copy link
Member

Bromeon commented Nov 10, 2023

These are not supported by Godot 4.1 in macOS, their exclusion is thus intentional.
For 4.2 builds (including custom-godot ones against dev), they are available.

See #405.

@Bromeon Bromeon closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
@Bromeon
Copy link
Member

Bromeon commented Nov 10, 2023

Wait, I just saw that your error mentions open_xr_interaction_profile_metadata -- this one is not in the list. Maybe we need to use OpenXR prefixes instead of hardcoding all concrete classes.

@kuruk-mm
Copy link
Contributor Author

These are not supported by Godot 4.1 in macOS, their exclusion is thus intentional. For 4.2 builds (including custom-godot ones against dev), they are available.

See #405.

I'm not using those. I'm just trying to fix the error that was blocking me.

I removed this in my Cargo.toml

[patch."https://github.com/godot-rust/godot4-prebuilt".godot4-prebuilt]
git = "https://github.com//godot-rust/godot4-prebuilt"
branch = "4.1.3"

and it started working. I don't understand well how the prebuild artifact works.

@kuruk-mm kuruk-mm changed the title (only mac) failed to resolve: could not find open_xr_action in engine (only mac) build fails due to failed to resolve: could not find open_xr_action in engine`` Nov 10, 2023
@kuruk-mm kuruk-mm changed the title (only mac) build fails due to failed to resolve: could not find open_xr_action in engine`` build fails in macos due to failed to resolve: could not find open_xr_action in engine Nov 10, 2023
@Bromeon
Copy link
Member

Bromeon commented Nov 10, 2023

Yep, see my last comment. #475 should fix this, could you check?

@Bromeon Bromeon reopened this Nov 10, 2023
@Bromeon Bromeon added bug c: engine Godot classes (nodes, resources, ...) labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: engine Godot classes (nodes, resources, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants