Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Volume Threshold parameter is missing from the config and also certain hystrix configs are mandatory. #5

Open
krriteshgupta opened this issue Jun 6, 2019 · 2 comments
Open

Request Volume Threshold parameter is missing from the config and also certain hystrix configs are mandatory. #5

krriteshgupta opened this issue Jun 6, 2019 · 2 comments

Comments

@krriteshgupta
Copy link

No description provided.

@krriteshgupta
Copy link
Author

krriteshgupta commented Jun 6, 2019 •
edited
Loading

The library does not have an option of client specifying circuitBreaker.requestVolumeThreshold config. And also I want to understand why certain hystrix config parameters are made compulsory when there are default values for them. Can we make them optional ?
I know the people who will/are using this library needs to have knowledge of hystrix and hence they will provide the required parameters, but what if he wants to go with default values shouldn't this library support that ?

@krriteshgupta krriteshgupta changed the title Request Volume Threshold parameter is missing from the config and also the certain hystrix configs are mandatory. Request Volume Threshold parameter is missing from the config and also certain hystrix configs are mandatory. Jun 6, 2019
@krriteshgupta
Copy link
Author

krriteshgupta commented Jun 8, 2019 •
edited
Loading

#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krriteshgupta