feature(spanner): Implement DML Support for Spanner #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtwatson
force-pushed
the
feature/spanner-client-enhancements
branch
from
c60aa87 to
be12225
Compare
jtwatson
changed the title
|
This PR supersedes the following PR #733, #910, #924 It is a robust implementation that greatly improves support for Spanner migrations. It also fixes a lot of open issues with the existing DDL parsing implementation. NOTE: Not sure why tests are failing, but it is not related to spanner tests. It looks like cockroachdb is having an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Closes #775
Closes #918
Closes #1194
Supersedes the following PRs #733, #910, #924
This PR implements DML support and uses the
memefishlexer to parse the migrations, replacing the usage of thespansqlpackage. As a result, numerous otherspansqlrelated issues have been resolved.The following features have been implemented:
To maintain backward compatibility, the
x-clean-statementsoption must be used to enable the above features.This PR also fixes a bug where a provided spanner client via
WithInstance()is closed whenMigration.Close()is called. According to Docs, the caller is responsible for closing the underlying database client. This fix brings the Spanner driver into compliance with the expected behavior.I am maintaining a fork with this fix for those who would like to use it.
Put the following replace directive you your projects
go.mod