Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.15.2 (from 0.15.1) resultts in go trimmed error #1990

Open
justinrush opened this issue Oct 2, 2024 · 2 comments
Open

Upgrade to 0.15.2 (from 0.15.1) resultts in go trimmed error #1990

justinrush opened this issue Oct 2, 2024 · 2 comments

Comments

@justinrush
Copy link

justinrush commented Oct 2, 2024

Describe the bug
A clear and concise description of what the bug is.

We upgraded from 0.15.1 to 0.15.2 and now a simple:

go get github.com/nats-io/nats.go@latest

Results in a 404.

Error Message

The athens error logs show:

INFO[4:49PM]: exit status 2: go: cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set
    http-method=GET http-path=/github.com/nats-io/@v/list kind=Not Found module= operation=download.ListHandler ops=[download.ListHandler pool.List protocol.List vcsLister.List] request-id=67210d5e-9557-4251-8661-1165b9eb8fb5 version= 
INFO[4:49PM]: incoming request    http-method=GET http-path=/github.com/nats-io/@v/list http-status=404 request-id=67210d5e-9557-4251-8661-1165b9eb8fb5 
INFO[4:49PM]: exit status 2: go: cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set
    http-method=GET http-path=/github.com/nats-io/nats.go/@v/list kind=Not Found module= operation=download.ListHandler ops=[download.ListHandler pool.List protocol.List vcsLister.List] request-id=ee1585b9-5125-410c-8257-482d8365fdf0 version= 
INFO[4:49PM]: incoming request    http-method=GET http-path=/github.com/nats-io/nats.go/@v/list http-status=404 request-id=ee1585b9-5125-410c-8257-482d8365fdf0 
INFO[4:49PM]: exit status 2: go: cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set
    http-method=GET http-path=/github.com/@v/list kind=Not Found module= operation=download.ListHandler ops=[download.ListHandler pool.List protocol.List vcsLister.List] request-id=6b3a1320-c0e7-4c3c-9510-fcc57efacfc6 version= 
INFO[4:49PM]: incoming request    http-method=GET http-path=/github.com/@v/list http-status=404 request-id=6b3a1320-c0e7-4c3c-9510-fcc57efacfc6 

To Reproduce
Steps to reproduce the behavior:

We downgraded to 0.15.1 and the problem went away. When we re-upgraded, the problem came back.

Expected behavior
A clear and concise description of what you expected to happen.

no errors.

Environment (please complete the following information):

  • OS: linux amd64 on Kubernetes
  • Go version : 1.22.2
  • Proxy version : 0.15.2
  • Storage (fs/mongodb/s3 etc.) : AKS PVC

Additional context

Our env is set to:

   - env:
     - name: ATHENS_GO_BINARY_ENV_VARS
       value: GOPRIVATE=go.ourprivatehost.com
     - name: ATHENS_DISK_STORAGE_ROOT
       value: /var/lib/athens
     - name: ATHENS_STORAGE_TYPE
       value: disk
     - name: ATHENS_GOGET_WORKERS
       value: "6"
     - name: ATHENS_GLOBAL_ENDPOINT
       value: https://proxy.golang.org

It looks like the new image 0.15.2 doesn't have GOROOT set but 0.15.1 does... running this fails for example:

$ nerdctl run --rm -it gomods/athens:v0.15.2 go version
go: cannot find GOROOT directory: 'go' binary is trimmed and GOROOT is not set
Error: exit status 2

I tried setting GOROOT manually to what 0.15.1 had (/usr/local/go). that. resolves the error seen with go version, but not the issues with athens itself.

@c-seeger
Copy link

c-seeger commented Oct 3, 2024

same issue here

@tbnguyen1407
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants