Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ActorNursery.run_in_actor() and offer as part of a wrapper cluster API #290

Open
3 tasks
goodboy opened this issue Jan 5, 2022 · 1 comment
Open
3 tasks
Labels
api cancellation SC teardown semantics and anti-zombie semantics help wanted Extra attention is needed process_spawning supervision testing

Comments

@goodboy
Copy link
Owner

goodboy commented Jan 5, 2022

I've rambled on wayyy too long in #287 but thanks to attempts to resolve that issue I think this is the way I'd like to go on a so called one shot task per actor-style "worker pool" API.

TDLR premises

ToDO

  • write up a version of .run_in_actor() style on top of the rest of the nursery API
  • convert the nested_multierrors() test to use the .open_context() / .run() style and ensure we can still get as reliable of performance
  • figure out how to offer the higher level / new .run_in_actor() API as a cluster helper
@goodboy goodboy added help wanted Extra attention is needed testing api supervision cancellation SC teardown semantics and anti-zombie semantics process_spawning labels Jan 5, 2022
@goodboy goodboy changed the title Deprecate ActorNursery.run_in_actor() and offer as part of a *wrapper* cluster API Deprecate ActorNursery.run_in_actor() and offer as part of a wrapper cluster API Jan 5, 2022
@goodboy
Copy link
Owner Author

goodboy commented Jan 6, 2022

A name came to me this morn:

  • async with tractor.open_task_pool() as cluster: or .open_actor_task_pool(), or we just do a simple .open_actor_cluster() as cluster: ?
  • provide a Cluster.run_in_actor()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api cancellation SC teardown semantics and anti-zombie semantics help wanted Extra attention is needed process_spawning supervision testing
Projects
None yet
Development

No branches or pull requests

1 participant