diff --git a/src/unsafe-rust/unsafe-traits.md b/src/unsafe-rust/unsafe-traits.md index f2ccdd2a30e..435a8790d8a 100644 --- a/src/unsafe-rust/unsafe-traits.md +++ b/src/unsafe-rust/unsafe-traits.md @@ -8,28 +8,24 @@ Like with functions, you can mark a trait as `unsafe` if the implementation must guarantee particular conditions to avoid undefined behaviour. For example, the `zerocopy` crate has an unsafe trait that looks -[something like this](https://docs.rs/zerocopy/latest/zerocopy/trait.AsBytes.html): +[something like this](https://docs.rs/zerocopy/latest/zerocopy/trait.IntoBytes.html): ```rust,editable -use std::mem::size_of_val; -use std::slice; +use std::{mem, slice}; /// ... /// # Safety /// The type must have a defined representation and no padding. -pub unsafe trait AsBytes { +pub unsafe trait IntoBytes { fn as_bytes(&self) -> &[u8] { - unsafe { - slice::from_raw_parts( - self as *const Self as *const u8, - size_of_val(self), - ) - } + let len = mem::size_of_val(self); + let slf: *const Self = self; + unsafe { slice::from_raw_parts(slf.cast::(), len) } } } -// SAFETY: `u32` has a defined representation and no padding. -unsafe impl AsBytes for u32 {} +/// SAFETY: `u32` has no padding bytes. +unsafe impl IntoBytes for u32 {} ```
@@ -37,7 +33,7 @@ unsafe impl AsBytes for u32 {} There should be a `# Safety` section on the Rustdoc for the trait explaining the requirements for the trait to be safely implemented. -The actual safety section for `AsBytes` is rather longer and more complicated. +The actual safety section for `IntoBytes` is rather longer and more complicated. The built-in `Send` and `Sync` traits are unsafe.