From 6e4d863e67c4fab5350407584ff4f29fa4ffc5be Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Mon, 28 Oct 2024 21:04:33 +0000 Subject: [PATCH] [ir] Update transform names when validating. This Cl updates the names used in validating the IR to always prefix with the language name. This makes it clearer when both core and language specific transforms with the same name execute which one you're looking at. Change-Id: I9c45126f3104a3bb26f88ca4b2bc84c4577c7cd3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/212574 Auto-Submit: dan sinclair Commit-Queue: James Price Reviewed-by: James Price --- src/tint/lang/core/ir/transform/add_empty_entry_point.cc | 2 +- src/tint/lang/core/ir/transform/array_length_from_uniform.cc | 2 +- src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc | 2 +- src/tint/lang/core/ir/transform/binary_polyfill.cc | 2 +- src/tint/lang/core/ir/transform/binding_remapper.cc | 2 +- src/tint/lang/core/ir/transform/block_decorated_structs.cc | 2 +- src/tint/lang/core/ir/transform/builtin_polyfill.cc | 2 +- src/tint/lang/core/ir/transform/combine_access_instructions.cc | 2 +- src/tint/lang/core/ir/transform/conversion_polyfill.cc | 2 +- src/tint/lang/core/ir/transform/demote_to_helper.cc | 2 +- src/tint/lang/core/ir/transform/direct_variable_access.cc | 2 +- .../lang/core/ir/transform/multiplanar_external_texture.cc | 2 +- src/tint/lang/core/ir/transform/prepare_push_constants.cc | 2 +- src/tint/lang/core/ir/transform/preserve_padding.cc | 2 +- src/tint/lang/core/ir/transform/remove_continue_in_switch.cc | 2 +- src/tint/lang/core/ir/transform/remove_terminator_args.cc | 2 +- src/tint/lang/core/ir/transform/rename_conflicts.cc | 2 +- src/tint/lang/core/ir/transform/robustness.cc | 2 +- src/tint/lang/core/ir/transform/single_entry_point.cc | 2 +- src/tint/lang/core/ir/transform/std140.cc | 2 +- src/tint/lang/core/ir/transform/value_to_let.cc | 2 +- .../core/ir/transform/vectorize_scalar_matrix_constructors.cc | 2 +- src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc | 2 +- src/tint/lang/glsl/writer/printer/printer.cc | 2 +- src/tint/lang/glsl/writer/raise/binary_polyfill.cc | 2 +- src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc | 2 +- src/tint/lang/glsl/writer/raise/builtin_polyfill.cc | 2 +- src/tint/lang/glsl/writer/raise/offset_first_index.cc | 2 +- src/tint/lang/glsl/writer/raise/shader_io.cc | 2 +- .../lang/glsl/writer/raise/texture_builtins_from_uniform.cc | 2 +- src/tint/lang/glsl/writer/raise/texture_polyfill.cc | 2 +- src/tint/lang/hlsl/writer/printer/printer.cc | 2 +- src/tint/lang/hlsl/writer/raise/binary_polyfill.cc | 2 +- src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc | 2 +- src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc | 2 +- src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc | 2 +- src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc | 2 +- .../lang/hlsl/writer/raise/localize_struct_array_assignment.cc | 2 +- src/tint/lang/hlsl/writer/raise/pixel_local.cc | 2 +- src/tint/lang/hlsl/writer/raise/promote_initializers.cc | 2 +- .../hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc | 2 +- src/tint/lang/hlsl/writer/raise/shader_io.cc | 2 +- src/tint/lang/msl/writer/printer/printer.cc | 2 +- src/tint/lang/msl/writer/raise/binary_polyfill.cc | 2 +- src/tint/lang/msl/writer/raise/builtin_polyfill.cc | 2 +- src/tint/lang/msl/writer/raise/module_scope_vars.cc | 2 +- src/tint/lang/msl/writer/raise/packed_vec3.cc | 2 +- src/tint/lang/msl/writer/raise/shader_io.cc | 2 +- src/tint/lang/msl/writer/raise/simd_ballot.cc | 2 +- src/tint/lang/msl/writer/raise/unary_polyfill.cc | 2 +- src/tint/lang/spirv/reader/lower/lower.cc | 3 +-- src/tint/lang/spirv/reader/lower/shader_io.cc | 2 +- src/tint/lang/spirv/reader/lower/vector_element_pointer.cc | 2 +- src/tint/lang/spirv/writer/printer/printer.cc | 2 +- src/tint/lang/spirv/writer/raise/builtin_polyfill.cc | 2 +- src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc | 2 +- src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc | 2 +- src/tint/lang/spirv/writer/raise/merge_return.cc | 2 +- src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc | 2 +- .../writer/raise/remove_unreachable_in_loop_continuing.cc | 2 +- src/tint/lang/spirv/writer/raise/shader_io.cc | 2 +- src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc | 2 +- src/tint/lang/wgsl/reader/lower/lower.cc | 2 +- src/tint/lang/wgsl/writer/raise/value_to_let.cc | 2 +- 64 files changed, 64 insertions(+), 65 deletions(-) diff --git a/src/tint/lang/core/ir/transform/add_empty_entry_point.cc b/src/tint/lang/core/ir/transform/add_empty_entry_point.cc index bb912248416..15107c37b55 100644 --- a/src/tint/lang/core/ir/transform/add_empty_entry_point.cc +++ b/src/tint/lang/core/ir/transform/add_empty_entry_point.cc @@ -54,7 +54,7 @@ void Run(ir::Module& ir) { Result AddEmptyEntryPoint(Module& ir) { auto result = ValidateAndDumpIfNeeded( - ir, "AddEmptyEntryPoint transform", + ir, "core.AddEmptyEntryPoint", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (result != Success) { return result.Failure(); diff --git a/src/tint/lang/core/ir/transform/array_length_from_uniform.cc b/src/tint/lang/core/ir/transform/array_length_from_uniform.cc index 0dd01ea2d17..63f4cb73d99 100644 --- a/src/tint/lang/core/ir/transform/array_length_from_uniform.cc +++ b/src/tint/lang/core/ir/transform/array_length_from_uniform.cc @@ -235,7 +235,7 @@ Result ArrayLengthFromUniform( Module& ir, BindingPoint ubo_binding, const std::unordered_map& bindpoint_to_size_index) { - auto validated = ValidateAndDumpIfNeeded(ir, "ArrayLengthFromUniform transform"); + auto validated = ValidateAndDumpIfNeeded(ir, "core.ArrayLengthFromUniform"); if (validated != Success) { return validated.Failure(); } diff --git a/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc b/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc index 8d1fd84216f..468c00851c3 100644 --- a/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc +++ b/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc @@ -182,7 +182,7 @@ struct State { } // namespace Result Bgra8UnormPolyfill(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "Bgra8UnormPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.Bgra8UnormPolyfill"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/binary_polyfill.cc b/src/tint/lang/core/ir/transform/binary_polyfill.cc index f609f281d98..4a2da27baa2 100644 --- a/src/tint/lang/core/ir/transform/binary_polyfill.cc +++ b/src/tint/lang/core/ir/transform/binary_polyfill.cc @@ -201,7 +201,7 @@ struct State { } // namespace Result BinaryPolyfill(Module& ir, const BinaryPolyfillConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.BinaryPolyfill"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/binding_remapper.cc b/src/tint/lang/core/ir/transform/binding_remapper.cc index 47d65ffc2d4..efa1e14bb4c 100644 --- a/src/tint/lang/core/ir/transform/binding_remapper.cc +++ b/src/tint/lang/core/ir/transform/binding_remapper.cc @@ -77,7 +77,7 @@ Result Run(ir::Module& ir, Result BindingRemapper( Module& ir, const std::unordered_map& binding_points) { - auto result = ValidateAndDumpIfNeeded(ir, "BindingRemapper transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.BindingRemapper"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/block_decorated_structs.cc b/src/tint/lang/core/ir/transform/block_decorated_structs.cc index 8478f358ef0..b565a7c1d95 100644 --- a/src/tint/lang/core/ir/transform/block_decorated_structs.cc +++ b/src/tint/lang/core/ir/transform/block_decorated_structs.cc @@ -120,7 +120,7 @@ void Run(Module& ir) { } // namespace Result BlockDecoratedStructs(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BlockDecoratedStructs transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.BlockDecoratedStructs"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/builtin_polyfill.cc b/src/tint/lang/core/ir/transform/builtin_polyfill.cc index 789cd716561..b668f2e6a81 100644 --- a/src/tint/lang/core/ir/transform/builtin_polyfill.cc +++ b/src/tint/lang/core/ir/transform/builtin_polyfill.cc @@ -930,7 +930,7 @@ struct State { } // namespace Result BuiltinPolyfill(Module& ir, const BuiltinPolyfillConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.BuiltinPolyfill"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/combine_access_instructions.cc b/src/tint/lang/core/ir/transform/combine_access_instructions.cc index 08a91f4fb3b..a65d04d13f2 100644 --- a/src/tint/lang/core/ir/transform/combine_access_instructions.cc +++ b/src/tint/lang/core/ir/transform/combine_access_instructions.cc @@ -80,7 +80,7 @@ struct State { } // namespace Result CombineAccessInstructions(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "CombineAccessInstructions transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.CombineAccessInstructions"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/conversion_polyfill.cc b/src/tint/lang/core/ir/transform/conversion_polyfill.cc index f4db087fb7c..becfdf9f7c8 100644 --- a/src/tint/lang/core/ir/transform/conversion_polyfill.cc +++ b/src/tint/lang/core/ir/transform/conversion_polyfill.cc @@ -189,7 +189,7 @@ struct State { } // namespace Result ConversionPolyfill(Module& ir, const ConversionPolyfillConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "ConversionPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.ConversionPolyfill"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/demote_to_helper.cc b/src/tint/lang/core/ir/transform/demote_to_helper.cc index 4c2ad12a6c6..ceb6f8f82d5 100644 --- a/src/tint/lang/core/ir/transform/demote_to_helper.cc +++ b/src/tint/lang/core/ir/transform/demote_to_helper.cc @@ -214,7 +214,7 @@ struct State { } // namespace Result DemoteToHelper(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "DemoteToHelper transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.DemoteToHelper", core::ir::Capabilities{ core::ir::Capability::kAllowVectorElementPointer, core::ir::Capability::kAllowClipDistancesOnF32, diff --git a/src/tint/lang/core/ir/transform/direct_variable_access.cc b/src/tint/lang/core/ir/transform/direct_variable_access.cc index 85ace989c96..67686ea5d43 100644 --- a/src/tint/lang/core/ir/transform/direct_variable_access.cc +++ b/src/tint/lang/core/ir/transform/direct_variable_access.cc @@ -704,7 +704,7 @@ struct State { } // namespace Result DirectVariableAccess(Module& ir, const DirectVariableAccessOptions& options) { - auto result = ValidateAndDumpIfNeeded(ir, "DirectVariableAccess transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.DirectVariableAccess", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc b/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc index 68793ea1577..9ad597e34f6 100644 --- a/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc +++ b/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc @@ -610,7 +610,7 @@ struct State { Result MultiplanarExternalTexture( Module& ir, const tint::transform::multiplanar::BindingsMap& multiplanar_map) { - auto result = ValidateAndDumpIfNeeded(ir, "MultiplanarExternalTexture transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.MultiplanarExternalTexture"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/prepare_push_constants.cc b/src/tint/lang/core/ir/transform/prepare_push_constants.cc index d32f4b0418b..b3f64b521bb 100644 --- a/src/tint/lang/core/ir/transform/prepare_push_constants.cc +++ b/src/tint/lang/core/ir/transform/prepare_push_constants.cc @@ -129,7 +129,7 @@ struct State { Result PreparePushConstants(Module& ir, const PreparePushConstantsConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "PreparePushConstants transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.PreparePushConstants"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/core/ir/transform/preserve_padding.cc b/src/tint/lang/core/ir/transform/preserve_padding.cc index 9ffb4a99767..463ebfa65c7 100644 --- a/src/tint/lang/core/ir/transform/preserve_padding.cc +++ b/src/tint/lang/core/ir/transform/preserve_padding.cc @@ -174,7 +174,7 @@ struct State { Result PreservePadding(Module& ir) { auto result = ValidateAndDumpIfNeeded( - ir, "PreservePadding transform", + ir, "core.PreservePadding", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (result != Success) { return result; diff --git a/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc b/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc index 3e7daffe7ad..997a9e10cfb 100644 --- a/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc +++ b/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc @@ -114,7 +114,7 @@ struct State { } // namespace Result RemoveContinueInSwitch(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "RemoveContinueInSwitch transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.RemoveContinueInSwitch", core::ir::Capabilities{ core::ir::Capability::kAllowVectorElementPointer, core::ir::Capability::kAllowHandleVarsWithoutBindings, diff --git a/src/tint/lang/core/ir/transform/remove_terminator_args.cc b/src/tint/lang/core/ir/transform/remove_terminator_args.cc index 95286220a80..7feb71d4c0f 100644 --- a/src/tint/lang/core/ir/transform/remove_terminator_args.cc +++ b/src/tint/lang/core/ir/transform/remove_terminator_args.cc @@ -164,7 +164,7 @@ struct State { } // namespace Result RemoveTerminatorArgs(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "RemoveTerminatorArgs transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.RemoveTerminatorArgs", core::ir::Capabilities{ core::ir::Capability::kAllow8BitIntegers, core::ir::Capability::kAllowPointersInStructures, diff --git a/src/tint/lang/core/ir/transform/rename_conflicts.cc b/src/tint/lang/core/ir/transform/rename_conflicts.cc index 1c168ca8a4f..d79ad9d65db 100644 --- a/src/tint/lang/core/ir/transform/rename_conflicts.cc +++ b/src/tint/lang/core/ir/transform/rename_conflicts.cc @@ -293,7 +293,7 @@ struct State { } // namespace Result RenameConflicts(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "RenameConflicts transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.RenameConflicts", core::ir::Capabilities{ core::ir::Capability::kAllow8BitIntegers, core::ir::Capability::kAllowPointersInStructures, diff --git a/src/tint/lang/core/ir/transform/robustness.cc b/src/tint/lang/core/ir/transform/robustness.cc index fa20c4f9c21..079a6cdd497 100644 --- a/src/tint/lang/core/ir/transform/robustness.cc +++ b/src/tint/lang/core/ir/transform/robustness.cc @@ -381,7 +381,7 @@ struct State { } // namespace Result Robustness(Module& ir, const RobustnessConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "Robustness transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.Robustness"); if (result != Success) { return result; } diff --git a/src/tint/lang/core/ir/transform/single_entry_point.cc b/src/tint/lang/core/ir/transform/single_entry_point.cc index 2282813226a..fac08142fe2 100644 --- a/src/tint/lang/core/ir/transform/single_entry_point.cc +++ b/src/tint/lang/core/ir/transform/single_entry_point.cc @@ -91,7 +91,7 @@ Result Run(ir::Module& ir, std::string_view entry_point_name) { } // namespace Result SingleEntryPoint(Module& ir, std::string_view entry_point_name) { - auto result = ValidateAndDumpIfNeeded(ir, "SingleEntryPoint transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.SingleEntryPoint"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/core/ir/transform/std140.cc b/src/tint/lang/core/ir/transform/std140.cc index 7b206dabb85..c799741ee79 100644 --- a/src/tint/lang/core/ir/transform/std140.cc +++ b/src/tint/lang/core/ir/transform/std140.cc @@ -451,7 +451,7 @@ struct State { Result Std140(Module& ir) { auto result = ValidateAndDumpIfNeeded( - ir, "Std140 transform", + ir, "core.Std140", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (result != Success) { return result; diff --git a/src/tint/lang/core/ir/transform/value_to_let.cc b/src/tint/lang/core/ir/transform/value_to_let.cc index 457ca799ef5..37946259bec 100644 --- a/src/tint/lang/core/ir/transform/value_to_let.cc +++ b/src/tint/lang/core/ir/transform/value_to_let.cc @@ -257,7 +257,7 @@ struct State { } // namespace Result ValueToLet(Module& ir, const ValueToLetConfig& cfg) { - auto result = ValidateAndDumpIfNeeded(ir, "ValueToLet transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.ValueToLet", core::ir::Capabilities{ core::ir::Capability::kAllow8BitIntegers, core::ir::Capability::kAllowPointersInStructures, diff --git a/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc b/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc index 57eebab3536..ec96c26b40e 100644 --- a/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc +++ b/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc @@ -94,7 +94,7 @@ struct State { } // namespace Result VectorizeScalarMatrixConstructors(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "VectorizeScalarMatrixConstructors transform", + auto result = ValidateAndDumpIfNeeded(ir, "core.VectorizeScalarMatrixConstructors", core::ir::Capabilities{ core::ir::Capability::kAllowVectorElementPointer, core::ir::Capability::kAllowHandleVarsWithoutBindings, diff --git a/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc b/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc index 95661834d38..4a5424bda77 100644 --- a/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc +++ b/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc @@ -305,7 +305,7 @@ struct State { } // namespace Result ZeroInitWorkgroupMemory(Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "ZeroInitWorkgroupMemory transform"); + auto result = ValidateAndDumpIfNeeded(ir, "core.ZeroInitWorkgroupMemory"); if (result != Success) { return result; } diff --git a/src/tint/lang/glsl/writer/printer/printer.cc b/src/tint/lang/glsl/writer/printer/printer.cc index 0afcb89724a..b79f5225707 100644 --- a/src/tint/lang/glsl/writer/printer/printer.cc +++ b/src/tint/lang/glsl/writer/printer/printer.cc @@ -117,7 +117,7 @@ class Printer : public tint::TextGenerator { /// @returns the generated GLSL shader tint::Result Generate() { auto valid = core::ir::ValidateAndDumpIfNeeded( - ir_, "GLSL writer", + ir_, "glsl.Printer", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (valid != Success) { return std::move(valid.Failure()); diff --git a/src/tint/lang/glsl/writer/raise/binary_polyfill.cc b/src/tint/lang/glsl/writer/raise/binary_polyfill.cc index b538f1adbe9..7a295c2f3f3 100644 --- a/src/tint/lang/glsl/writer/raise/binary_polyfill.cc +++ b/src/tint/lang/glsl/writer/raise/binary_polyfill.cc @@ -216,7 +216,7 @@ struct State { } // namespace Result BinaryPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "glsl.BinaryPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "glsl.BinaryPolyfill"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc b/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc index 476c9a98f1c..d8560af8fce 100644 --- a/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc +++ b/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc @@ -279,7 +279,7 @@ struct State { Result BitcastPolyfill(core::ir::Module& ir) { auto result = ValidateAndDumpIfNeeded( - ir, "glsl::BitcastPolyfill transform", + ir, "glsl.BitcastPolyfill", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (result != Success) { return result.Failure(); diff --git a/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc b/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc index 1711137422d..b82c366d9b5 100644 --- a/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc +++ b/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc @@ -527,7 +527,7 @@ struct State { } // namespace Result BuiltinPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "glsl.BuiltinPolyfill"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/glsl/writer/raise/offset_first_index.cc b/src/tint/lang/glsl/writer/raise/offset_first_index.cc index dd431ad1339..3ef806f7e58 100644 --- a/src/tint/lang/glsl/writer/raise/offset_first_index.cc +++ b/src/tint/lang/glsl/writer/raise/offset_first_index.cc @@ -110,7 +110,7 @@ struct State { } // namespace Result OffsetFirstIndex(core::ir::Module& ir, const OffsetFirstIndexConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "glsl.OffsetFirstIndex transform", + auto result = ValidateAndDumpIfNeeded(ir, "glsl.OffsetFirstIndex", core::ir::Capabilities{ core::ir::Capability::kAllowHandleVarsWithoutBindings, }); diff --git a/src/tint/lang/glsl/writer/raise/shader_io.cc b/src/tint/lang/glsl/writer/raise/shader_io.cc index 2e6054ce9f0..95e4f4cd94a 100644 --- a/src/tint/lang/glsl/writer/raise/shader_io.cc +++ b/src/tint/lang/glsl/writer/raise/shader_io.cc @@ -263,7 +263,7 @@ struct StateImpl : core::ir::transform::ShaderIOBackendState { Result ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) { auto result = ValidateAndDumpIfNeeded( - ir, "ShaderIO transform", + ir, "gls.lShaderIO", core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings}); if (result != Success) { return result; diff --git a/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc b/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc index 48e144e942c..3db84fdac3b 100644 --- a/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc +++ b/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc @@ -217,7 +217,7 @@ struct State { Result TextureBuiltinsFromUniform(core::ir::Module& ir, const TextureBuiltinsFromUniformOptions& cfg) { - auto result = ValidateAndDumpIfNeeded(ir, "glsl.TextureBuiltinsFromUniform transform"); + auto result = ValidateAndDumpIfNeeded(ir, "glsl.TextureBuiltinsFromUniform"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/glsl/writer/raise/texture_polyfill.cc b/src/tint/lang/glsl/writer/raise/texture_polyfill.cc index a7e9a513014..6d1b55a53b9 100644 --- a/src/tint/lang/glsl/writer/raise/texture_polyfill.cc +++ b/src/tint/lang/glsl/writer/raise/texture_polyfill.cc @@ -1217,7 +1217,7 @@ struct State { } // namespace Result TexturePolyfill(core::ir::Module& ir, const TexturePolyfillConfig& cfg) { - auto result = ValidateAndDumpIfNeeded(ir, "glsl.TexturePolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "glsl.TexturePolyfill"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/hlsl/writer/printer/printer.cc b/src/tint/lang/hlsl/writer/printer/printer.cc index 34ce4ea9d74..89a9fff6602 100644 --- a/src/tint/lang/hlsl/writer/printer/printer.cc +++ b/src/tint/lang/hlsl/writer/printer/printer.cc @@ -160,7 +160,7 @@ class Printer : public tint::TextGenerator { core::ir::Capability::kAllowVectorElementPointer, core::ir::Capability::kAllowClipDistancesOnF32, }; - auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "HLSL writer", capabilities); + auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "hlsl.Printer", capabilities); if (valid != Success) { return std::move(valid.Failure()); } diff --git a/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc b/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc index e3f4587b1bf..93ffba66582 100644 --- a/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc +++ b/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc @@ -136,7 +136,7 @@ struct State { } // namespace Result BinaryPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.BinaryPolyfill", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc b/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc index f1b5f3653b8..222465fd5c4 100644 --- a/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc +++ b/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc @@ -1924,7 +1924,7 @@ struct State { } // namespace Result BuiltinPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.BuiltinPolyfill", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc b/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc index 288bb3cdf96..a5deb31518e 100644 --- a/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc +++ b/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc @@ -898,7 +898,7 @@ struct State { } // namespace Result DecomposeStorageAccess(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "DecomposeStorageAccess transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.DecomposeStorageAccess", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc b/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc index dd1d9a2924d..5d237f83fb1 100644 --- a/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc +++ b/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc @@ -586,7 +586,7 @@ struct State { } // namespace Result DecomposeUniformAccess(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "DecomposeUniformAccess transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.DecomposeUniformAccess", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc b/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc index 7369b400bcf..1d332e2eeed 100644 --- a/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc +++ b/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc @@ -75,7 +75,7 @@ struct State { } // namespace Result FxcPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "FxcPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.FxcPolyfill"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc b/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc index 638d0894073..c5d08d7108b 100644 --- a/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc +++ b/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc @@ -158,7 +158,7 @@ struct State { } // namespace Result LocalizeStructArrayAssignment(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "LocalizeStructArrayAssignment transform"); + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.LocalizeStructArrayAssignment"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/hlsl/writer/raise/pixel_local.cc b/src/tint/lang/hlsl/writer/raise/pixel_local.cc index 962258f8fe2..e6d8ab01c5f 100644 --- a/src/tint/lang/hlsl/writer/raise/pixel_local.cc +++ b/src/tint/lang/hlsl/writer/raise/pixel_local.cc @@ -245,7 +245,7 @@ struct State { } // namespace Result PixelLocal(core::ir::Module& ir, const PixelLocalConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "PixelLocal transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.PixelLocal", core::ir::Capabilities{ core::ir::Capability::kAllowClipDistancesOnF32, }); diff --git a/src/tint/lang/hlsl/writer/raise/promote_initializers.cc b/src/tint/lang/hlsl/writer/raise/promote_initializers.cc index 3d0bb78a9ce..e09b39f5b7e 100644 --- a/src/tint/lang/hlsl/writer/raise/promote_initializers.cc +++ b/src/tint/lang/hlsl/writer/raise/promote_initializers.cc @@ -238,7 +238,7 @@ struct State { } // namespace Result PromoteInitializers(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "PromoteInitializers transform", + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.PromoteInitializers", core::ir::Capabilities{ core::ir::Capability::kAllowVectorElementPointer, core::ir::Capability::kAllowClipDistancesOnF32, diff --git a/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc b/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc index 1cf3f3fbf39..8f06a5076e4 100644 --- a/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc +++ b/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc @@ -287,7 +287,7 @@ struct State { } // namespace Result ReplaceNonIndexableMatVecStores(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "ReplaceNonIndexableMatVecStores transform"); + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.ReplaceNonIndexableMatVecStores"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/hlsl/writer/raise/shader_io.cc b/src/tint/lang/hlsl/writer/raise/shader_io.cc index b19edf2f35f..cf58e376fbb 100644 --- a/src/tint/lang/hlsl/writer/raise/shader_io.cc +++ b/src/tint/lang/hlsl/writer/raise/shader_io.cc @@ -471,7 +471,7 @@ struct StateImpl : core::ir::transform::ShaderIOBackendState { } // namespace Result ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform"); + auto result = ValidateAndDumpIfNeeded(ir, "hlsl.ShaderIO"); if (result != Success) { return result; } diff --git a/src/tint/lang/msl/writer/printer/printer.cc b/src/tint/lang/msl/writer/printer/printer.cc index aa843212fca..9d2b0a1a7c7 100644 --- a/src/tint/lang/msl/writer/printer/printer.cc +++ b/src/tint/lang/msl/writer/printer/printer.cc @@ -118,7 +118,7 @@ class Printer : public tint::TextGenerator { /// @returns the generated MSL shader tint::Result Generate() { auto valid = - core::ir::ValidateAndDumpIfNeeded(ir_, "MSL writer", + core::ir::ValidateAndDumpIfNeeded(ir_, "msl.Printer", core::ir::Capabilities{ core::ir::Capability::kAllow8BitIntegers, core::ir::Capability::kAllowPointersInStructures, diff --git a/src/tint/lang/msl/writer/raise/binary_polyfill.cc b/src/tint/lang/msl/writer/raise/binary_polyfill.cc index 13e09e1990b..bdf4b0739d3 100644 --- a/src/tint/lang/msl/writer/raise/binary_polyfill.cc +++ b/src/tint/lang/msl/writer/raise/binary_polyfill.cc @@ -157,7 +157,7 @@ struct State { } // namespace Result BinaryPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform", + auto result = ValidateAndDumpIfNeeded(ir, "msl.BinaryPolyfill", core::ir::Capabilities{ core::ir::Capability::kAllowPointersInStructures, }); diff --git a/src/tint/lang/msl/writer/raise/builtin_polyfill.cc b/src/tint/lang/msl/writer/raise/builtin_polyfill.cc index 185edd572e6..8f3983a35d5 100644 --- a/src/tint/lang/msl/writer/raise/builtin_polyfill.cc +++ b/src/tint/lang/msl/writer/raise/builtin_polyfill.cc @@ -933,7 +933,7 @@ struct State { } // namespace Result BuiltinPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform", + auto result = ValidateAndDumpIfNeeded(ir, "msl.BuiltinPolyfill", core::ir::Capabilities{ core::ir::Capability::kAllowPointersInStructures, }); diff --git a/src/tint/lang/msl/writer/raise/module_scope_vars.cc b/src/tint/lang/msl/writer/raise/module_scope_vars.cc index 8727e399fa4..a5cfadb204d 100644 --- a/src/tint/lang/msl/writer/raise/module_scope_vars.cc +++ b/src/tint/lang/msl/writer/raise/module_scope_vars.cc @@ -317,7 +317,7 @@ struct State { } // namespace Result ModuleScopeVars(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "ModuleScopeVars transform"); + auto result = ValidateAndDumpIfNeeded(ir, "msl.ModuleScopeVars"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/msl/writer/raise/packed_vec3.cc b/src/tint/lang/msl/writer/raise/packed_vec3.cc index aa059e60b26..36c9faef0e3 100644 --- a/src/tint/lang/msl/writer/raise/packed_vec3.cc +++ b/src/tint/lang/msl/writer/raise/packed_vec3.cc @@ -633,7 +633,7 @@ struct State { } // namespace Result PackedVec3(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "PackedVec3 transform"); + auto result = ValidateAndDumpIfNeeded(ir, "msl.PackedVec3"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/msl/writer/raise/shader_io.cc b/src/tint/lang/msl/writer/raise/shader_io.cc index 018519cd767..caa6f083459 100644 --- a/src/tint/lang/msl/writer/raise/shader_io.cc +++ b/src/tint/lang/msl/writer/raise/shader_io.cc @@ -244,7 +244,7 @@ struct StateImpl : core::ir::transform::ShaderIOBackendState { } // namespace Result ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform"); + auto result = ValidateAndDumpIfNeeded(ir, "msl.ShaderIO"); if (result != Success) { return result; } diff --git a/src/tint/lang/msl/writer/raise/simd_ballot.cc b/src/tint/lang/msl/writer/raise/simd_ballot.cc index 1b4c84c18eb..5d95b5b13f6 100644 --- a/src/tint/lang/msl/writer/raise/simd_ballot.cc +++ b/src/tint/lang/msl/writer/raise/simd_ballot.cc @@ -160,7 +160,7 @@ struct State { } // namespace Result SimdBallot(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "SimdBallot transform"); + auto result = ValidateAndDumpIfNeeded(ir, "msl.SimdBallot"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/msl/writer/raise/unary_polyfill.cc b/src/tint/lang/msl/writer/raise/unary_polyfill.cc index 167dcb1df22..940f16acb51 100644 --- a/src/tint/lang/msl/writer/raise/unary_polyfill.cc +++ b/src/tint/lang/msl/writer/raise/unary_polyfill.cc @@ -88,7 +88,7 @@ struct State { } // namespace Result UnaryPolyfill(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "UnaryPolyfill transform", + auto result = ValidateAndDumpIfNeeded(ir, "msl.UnaryPolyfill", core::ir::Capabilities{ core::ir::Capability::kAllowPointersInStructures, }); diff --git a/src/tint/lang/spirv/reader/lower/lower.cc b/src/tint/lang/spirv/reader/lower/lower.cc index 433d0cda943..f1861d45cd8 100644 --- a/src/tint/lang/spirv/reader/lower/lower.cc +++ b/src/tint/lang/spirv/reader/lower/lower.cc @@ -45,8 +45,7 @@ Result Lower(core::ir::Module& mod) { RUN_TRANSFORM(lower::VectorElementPointer, mod); RUN_TRANSFORM(lower::ShaderIO, mod); - if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "end of lowering from SPIR-V"); - res != Success) { + if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "spirv.Lower"); res != Success) { return res.Failure(); } diff --git a/src/tint/lang/spirv/reader/lower/shader_io.cc b/src/tint/lang/spirv/reader/lower/shader_io.cc index 24d460198f8..294f859613a 100644 --- a/src/tint/lang/spirv/reader/lower/shader_io.cc +++ b/src/tint/lang/spirv/reader/lower/shader_io.cc @@ -384,7 +384,7 @@ struct State { } // namespace Result ShaderIO(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.ShaderIO"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc b/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc index fa84275e277..f1f14cc6037 100644 --- a/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc +++ b/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc @@ -153,7 +153,7 @@ struct State { } // namespace Result VectorElementPointer(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "VectorElementPointer transform", + auto result = ValidateAndDumpIfNeeded(ir, "spirv.VectorElementPointer", core::ir::Capabilities{ core::ir::Capability::kAllowVectorElementPointer, }); diff --git a/src/tint/lang/spirv/writer/printer/printer.cc b/src/tint/lang/spirv/writer/printer/printer.cc index c539a97b7b7..068b03346eb 100644 --- a/src/tint/lang/spirv/writer/printer/printer.cc +++ b/src/tint/lang/spirv/writer/printer/printer.cc @@ -278,7 +278,7 @@ class Printer { /// Builds the SPIR-V from the IR Result Generate() { - auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "SPIR-V writer"); + auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "spirv.Printer"); if (valid != Success) { return valid.Failure(); } diff --git a/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc b/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc index a414f7aecf3..1048fbcd196 100644 --- a/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc +++ b/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc @@ -959,7 +959,7 @@ struct State { } // namespace Result BuiltinPolyfill(core::ir::Module& ir, bool use_vulkan_memory_model) { - auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.BuiltinPolyfill"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc b/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc index 2f4fdd7f6b5..c0d2f34270e 100644 --- a/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc +++ b/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc @@ -135,7 +135,7 @@ struct State { } // namespace Result ExpandImplicitSplats(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "ExpandImplicitSplats transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.ExpandImplicitSplats"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc b/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc index cf7f106e2a4..679f4e0d401 100644 --- a/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc +++ b/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc @@ -163,7 +163,7 @@ struct State { } // namespace Result HandleMatrixArithmetic(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "HandleMatrixArithmetic transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.HandleMatrixArithmetic"); if (result != Success) { return result.Failure(); } diff --git a/src/tint/lang/spirv/writer/raise/merge_return.cc b/src/tint/lang/spirv/writer/raise/merge_return.cc index dbfb4f1942e..47de1b8b434 100644 --- a/src/tint/lang/spirv/writer/raise/merge_return.cc +++ b/src/tint/lang/spirv/writer/raise/merge_return.cc @@ -322,7 +322,7 @@ struct State { } // namespace Result MergeReturn(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "MergeReturn transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.MergeReturn"); if (result != Success) { return result; } diff --git a/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc b/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc index ac58a5abc67..85b5d0429b0 100644 --- a/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc +++ b/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc @@ -128,7 +128,7 @@ struct State { } // namespace Result PassMatrixByPointer(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "PassMatrixByPointer transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.PassMatrixByPointer"); if (result != Success) { return result; } diff --git a/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc b/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc index 4f1fcdbcb45..5f534b4810d 100644 --- a/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc +++ b/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc @@ -94,7 +94,7 @@ struct State { } // namespace Result RemoveUnreachableInLoopContinuing(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "RemoveUnreachableInLoopContinuing transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.RemoveUnreachableInLoopContinuing"); if (result != Success) { return result; } diff --git a/src/tint/lang/spirv/writer/raise/shader_io.cc b/src/tint/lang/spirv/writer/raise/shader_io.cc index 53ae7a49896..14c9e53ce4f 100644 --- a/src/tint/lang/spirv/writer/raise/shader_io.cc +++ b/src/tint/lang/spirv/writer/raise/shader_io.cc @@ -235,7 +235,7 @@ struct StateImpl : core::ir::transform::ShaderIOBackendState { } // namespace Result ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) { - auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.ShaderIO"); if (result != Success) { return result; } diff --git a/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc b/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc index 49655d5a436..ea336ae4169 100644 --- a/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc +++ b/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc @@ -251,7 +251,7 @@ struct State { } // namespace Result VarForDynamicIndex(core::ir::Module& ir) { - auto result = ValidateAndDumpIfNeeded(ir, "VarForDynamicIndex transform"); + auto result = ValidateAndDumpIfNeeded(ir, "spirv.VarForDynamicIndex"); if (result != Success) { return result; } diff --git a/src/tint/lang/wgsl/reader/lower/lower.cc b/src/tint/lang/wgsl/reader/lower/lower.cc index f7e690cb897..02ba26e25f4 100644 --- a/src/tint/lang/wgsl/reader/lower/lower.cc +++ b/src/tint/lang/wgsl/reader/lower/lower.cc @@ -204,7 +204,7 @@ core::BuiltinFn Convert(wgsl::BuiltinFn fn) { } // namespace Result Lower(core::ir::Module& mod) { - if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "lowering from WGSL"); res != Success) { + if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "wgsl.Lower"); res != Success) { return res.Failure(); } diff --git a/src/tint/lang/wgsl/writer/raise/value_to_let.cc b/src/tint/lang/wgsl/writer/raise/value_to_let.cc index 32e98b33ad5..44fe8e5834b 100644 --- a/src/tint/lang/wgsl/writer/raise/value_to_let.cc +++ b/src/tint/lang/wgsl/writer/raise/value_to_let.cc @@ -186,7 +186,7 @@ struct State { } // namespace Result ValueToLet(core::ir::Module& ir) { - auto result = core::ir::ValidateAndDumpIfNeeded(ir, "ValueToLet transform"); + auto result = core::ir::ValidateAndDumpIfNeeded(ir, "wgsl.ValueToLet"); if (result != Success) { return result; }