-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggcr: use ETags in pkg/v1/remote #1333
Comments
This issue is stale because it has been open for 90 days with no |
This issue is stale because it has been open for 90 days with no |
This would be a really nice feature to add. I think a user of the library could hack this in by modifying the transport but that would be ugly. It would be as simple as adding the ETag (if present) to the Image (or ImageIndex) upon pull. Then extracted (if available) when pushing to a tag and add the If-Match header. Note that this would only apply when pushing to (really updating) a tag (which is the only mutable thing in a registry). It does not make sense for any other type of REST request to the registry. |
I had an attempt at this here: #1386 It stalled out, but might be worth revisiting if you're interested. |
When pulling a manifest by tag, if the response includes an
ETag
header, we should hold on to it, and pass it in any future updates to that tag using theIf-Match
header, as described in this proposal: opencontainers/distribution-spec#250This prevents race conditions, especially when appending a manifest to an index.
@jonjohnsonjr
The text was updated successfully, but these errors were encountered: