PermissionDeniedDialogTest and SignInError Test Coverage #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2806 +/- ##
============================================
+ Coverage 61.13% 61.93% +0.80%
- Complexity 1162 1166 +4
============================================
Files 265 265
Lines 6221 6221
Branches 878 878
============================================
+ Hits 3803 3853 +50
+ Misses 1900 1840 -60
- Partials 518 528 +10 |
shobhitagarwal1612
requested changes
Nov 2, 2024
ground/src/main/java/com/google/android/ground/PermissionDeniedDialog.kt
Outdated
Show resolved
Hide resolved
ground/src/test/java/com/google/android/ground/PermissionDeniedDialogTest.kt
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Nov 3, 2024
anandwana001
deleted the
anandwana001/2805/permission-denied-dialog-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
@shobhitagarwal1612 PTAL?