Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust build image needs updating #12410

Open
nathaniel-brough opened this issue Aug 27, 2024 · 5 comments
Open

Rust build image needs updating #12410

nathaniel-brough opened this issue Aug 27, 2024 · 5 comments

Comments

@nathaniel-brough
Copy link
Contributor

nathaniel-brough commented Aug 27, 2024

There are quite a number of rust projects that are not building because they depend on the serde crate. But the serde crate requires a more up to date version of rustc (as the current version hasn't been updated since febuary). This is the error across many repositories that have failing builds.

add `#![feature(diagnostic_namespace)]` to the crate attributes to enable�[0m
Step #3 - "compile-libfuzzer-address-x86_64": �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: this compiler was built on 2024-02-11; consider upgrading it if it is out of date�[0m
Step #3 - "compile-libfuzzer-address-x86_64": 
Step #3 - "compile-libfuzzer-address-x86_64": �[0m�[1mFor more information about this error, try `rustc --explain E0658`.�[0m
Step #3 - "compile-libfuzzer-address-x86_64": The following warnings were emitted during compilation:

So far I've fixed two rounds of builds by simple updating rustc in the project specific Dockerfile e.g.

@nathaniel-brough
Copy link
Contributor Author

nathaniel-brough commented Aug 27, 2024

Also you appear to have a spam problem...

EDIT: There was some obviously spammy/phishy comment's earlier in the thread that I reported and appear to have been removed by the github security team.

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2024

So far I've fixed two rounds of builds by simple updating rustc in the project specific Dockerfile e.g.

I haven't checked, but I think this will break their coverage build.

See also #11626 and #12365

@nathaniel-brough
Copy link
Contributor Author

I mean all the builds for the projects i linked are already broken. So I'm not fixing one build at the expense of another because neither the normal builds or the coverage builds are working. That being said I can see the conundrum regarding updating the image in the context of the two issues you linked.

@maflcko
Copy link
Contributor

maflcko commented Aug 27, 2024

Sure, your reply and your approach makes sense. However, I think this issue is already tracked in #11626 and attempted to be fixed in #12365, so I think this one can be closed?

@nathaniel-brough
Copy link
Contributor Author

Hmm I think the issues you've linked are related but aren't the same issue. In fact I think the temporary workaround to the problem you've linked is what has caused the issue with building serde. So I'd say they are kind of separate and apposing issues, until both can be fixed simultaneously. Is that roughly what you are getting at i.e. you believe this issue (with building serde) would be fixed by #12365?

EliahKagan added a commit to EliahKagan/oss-fuzz that referenced this issue Sep 18, 2024
Since around GitoxideLabs/gitoxide#1536, fuzzing
is broken for `gitoxide` due to an error related to `serde`. As
shown there and in GitoxideLabs/gitoxide#1596, the
error is:

    error[E0658]: `#[diagnostic]` attribute name space is experimental
       --> /rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5
        |
    536 |     diagnostic::on_unimplemented(
        |     ^^^^^^^^^^
        |
        = note: see issue #111996 <rust-lang/rust#111996> for more information
        = help: add `#![feature(diagnostic_namespace)]` to the crate attributes to enable
        = note: this compiler was built on 2024-02-11; consider upgrading it if it is out of date

Since rust-lang/rust#111996 is closed as
completed, and similar errors appear to have been fixed in oss-fuzz
for other projects by using the latest nightly toolchain, this
makes the same change for `gitoxide` as was made in

- google#12404 for `starlark-rust`
- google#12409 for `rhai`

See also google#12410.
EliahKagan added a commit to EliahKagan/oss-fuzz that referenced this issue Sep 18, 2024
Since around GitoxideLabs/gitoxide#1536, fuzzing
is broken for `gitoxide` due to an error related to `serde`. As
shown there and in GitoxideLabs/gitoxide#1596, the
error is:

    error[E0658]: `#[diagnostic]` attribute name space is experimental
       --> /rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5
        |
    536 |     diagnostic::on_unimplemented(
        |     ^^^^^^^^^^
        |
        = note: see issue #111996 <rust-lang/rust#111996> for more information
        = help: add `#![feature(diagnostic_namespace)]` to the crate attributes to enable
        = note: this compiler was built on 2024-02-11; consider upgrading it if it is out of date

Since rust-lang/rust#111996 is closed as
completed, and similar errors appear to have been fixed in oss-fuzz
for other projects by using the latest nightly toolchain, this
makes the same change for `gitoxide` as was made in:

- google#12404 for `starlark-rust`
- google#12409 for `rhai`

See also :

- google#12410
- serde-rs/serde#2770
DavidKorczynski pushed a commit that referenced this issue Sep 18, 2024
Since around GitoxideLabs/gitoxide#1536, fuzzing is
broken for `gitoxide` due to an error related to `serde`. As shown there
and in GitoxideLabs/gitoxide#1596, the error is:

    error[E0658]: `#[diagnostic]` attribute name space is experimental
-->
/rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5
        |
    536 |     diagnostic::on_unimplemented(
        |     ^^^^^^^^^^
        |
= note: see issue #111996
<rust-lang/rust#111996> for more information
= help: add `#![feature(diagnostic_namespace)]` to the crate attributes
to enable
= note: this compiler was built on 2024-02-11; consider upgrading it if
it is out of date

Since rust-lang/rust#111996 is closed as
completed, and similar errors appear to have been fixed in oss-fuzz for
other projects by using the latest nightly toolchain, this makes the
same change for `gitoxide` as was made in:

- #12404 for `starlark-rust`
- #12409 for `rhai`

See also:

- #12410
- serde-rs/serde#2770

cc @Byron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@maflcko @nathaniel-brough and others