You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The protobuf dependecy configuration (used to pull in artifacts containing proto files that need code generation) appears to mark both isCanBeConsumed and isCanBeResolved as true, which is no longer recommended by Gradle (table just above here.
The protobuf configuration doesn't produce an artifact/variant, so it should probably have isCanBeConsumed set to false.
This usually isn't an issue, but in some situations the incorrect indication that protobuf is an outgoing variant can make configuring/customize variant selection difficult.
For example, if a plugin adds an outgoing variant that can be used by consumers with the protobuf configuration, and also wants the make the protobuf configuration prefer variants tagget with a certain attribute, the vestigial isCanBeConsumedprotobuf configuration causes variant selection ambiguity.
I can work around this myself by disabling isCanBeConsumed on protobuf myself, but ideally the protobuf-gradle-plugin configurations would have the resolvable/consumable flags set appropriately.
This would be a fairly minor change here to set the consumable flag to false.
I'm not aware if this behavior is relied upon somehow, but I don't see any variant configuration associated with these configurations, so it appears to be safe.
The text was updated successfully, but these errors were encountered:
The
protobuf
dependecy configuration (used to pull in artifacts containingproto
files that need code generation) appears to mark bothisCanBeConsumed
andisCanBeResolved
astrue
, which is no longer recommended by Gradle (table just above here.The
protobuf
configuration doesn't produce an artifact/variant, so it should probably haveisCanBeConsumed
set to false.This usually isn't an issue, but in some situations the incorrect indication that
protobuf
is an outgoing variant can make configuring/customize variant selection difficult.For example, if a plugin adds an outgoing variant that can be used by consumers with the
protobuf
configuration, and also wants the make theprotobuf
configuration prefer variants tagget with a certain attribute, the vestigialisCanBeConsumed
protobuf
configuration causes variant selection ambiguity.I can work around this myself by disabling
isCanBeConsumed
onprotobuf
myself, but ideally theprotobuf-gradle-plugin
configurations would have the resolvable/consumable flags set appropriately.This would be a fairly minor change here to set the consumable flag to
false
.I'm not aware if this behavior is relied upon somehow, but I don't see any variant configuration associated with these configurations, so it appears to be safe.
The text was updated successfully, but these errors were encountered: