Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings args do not need to be parsed. #459

Open
hxse opened this issue Jul 11, 2023 · 3 comments
Open

Strings args do not need to be parsed. #459

hxse opened this issue Jul 11, 2023 · 3 comments

Comments

@hxse
Copy link

hxse commented Jul 11, 2023

def test(a, b):
    print(a, b)

if __name__ == "__main__":
    fire.Fire(test)

python .\test.py 1 '2 3'
1 2 3

python .\test2.py 1 '""2 3""'
1 2 3

python .\test.py 1 '--2 3'
ERROR: The function received no value for the required argument: b

python .\test.py 1 '\"2 3\"'

1 "2
ERROR: Could not consume arg: 3"

python .\test.py 1 '\"\"2 3\"\"'
1 ""2 3""

The correct behavior should be equivalent to print(1, "2 3"), so strings args do not need to be parsed.

@DavidFarago
Copy link

I guess not parsing string args will also fix the following problem, right?

I have with the following code:

def preprocess(data_path: str = "data.json", output_format: str):
...

if __name__ == "__main__":
    fire.Fire(preprocess)

If I call python preprocess.py --data_path foo.json --output_format "{response}", I get the error AttributeError: 'set' object has no attribute 'format' because type(output_format) = set and not str.

@Dragon-Git
Copy link

I also encountered a similar issue when passing a string starting with "-" , but it can be passed by explicitly specifying the parameter name, for example:

import fire

def test(a, b):
    print(a, b)
    print(type(a), type(b))

if __name__ == "__main__":
    fire.Fire(test)
python ./test.py -a=1 -b='--2 3'
1 --2 3
<class 'int'> <class 'str'>

@pioneerHitesh
Copy link

I would like to pick this one up can it be assigned to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants