Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport table_id to MetricsTracer #1882

Closed
wants to merge 7 commits into from

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Aug 10, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #468 ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested a review from a team as a code owner August 10, 2023 15:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 10, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Aug 10, 2023
@mutianf mutianf changed the title fix: backport table_id to MetricsTracer feat: backport table_id to MetricsTracer Aug 10, 2023
@igorbernstein2
Copy link
Contributor

closing in favor of #1796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add bigtable_table_id attribute to opencensus stats / traces
2 participants