Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: add samples for Cloud Storage ingestion, and a few small fixes #1985

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Oct 10, 2024

This adds TS/JS samples for Cloud Storage ingestion, plus two fixes:

  • a paste-o for Kinesis ingestion
  • a Typeless bot invocation issue

@feywind feywind requested review from a team as code owners October 10, 2024 22:11
Copy link

snippet-bot bot commented Oct 10, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Oct 10, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2024
Copy link

Warning: This pull request is touching the following templated files:

@michaelpri10
Copy link

LGTM, thank you!

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 15, 2024
@feywind feywind added the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2024
@feywind feywind merged commit fbd7359 into googleapis:main Oct 15, 2024
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2024
@feywind feywind deleted the gcs-ingestion-samples branch October 15, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants