Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials end up in the repo to be cloned #19

Open
jensklose opened this issue Dec 22, 2021 · 3 comments
Open

Credentials end up in the repo to be cloned #19

jensklose opened this issue Dec 22, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@jensklose
Copy link
Contributor

Further research needed! I got this issue on an empty repo and a credential helper with a mounted store.

$ git clone http://localhost:3000/jens/store-team1.git
Cloning into 'store-team1'...
Username for 'http://localhost:3000': jens
Password for 'http://jens@localhost:3000':
⚠ Failed to pull before git push: exit status 1: fatal: couldn't find remote ref master
warning: You appear to have cloned an empty repository.
$ cd store-team1/

$ git status
On branch master
Your branch is based on 'origin/master', but the upstream is gone.
  (use "git branch --unset-upstream" to fixup)

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    git/localhost_3000/jens.gpg

no changes added to commit (use "git add" and/or "git commit -a")

image

@varac
Copy link

varac commented Mar 6, 2023

I encountered the same today, which is really worrysome, because I am using a public dotfiles repository and the (ok, gpg-encrypted) password was automatically pushed. So I needed to force-push to my public (protected) main branch, so yeah.
Please look into this, meanwhile I'll stop using this otherwise awesome git integration and use a local unencrypted git credential store until this get fixed. Thanks!

@varac
Copy link

varac commented Mar 6, 2023

And probably this already affects other users as well, since pushing is transparent and you don't really notice easily that sth leaked.

@dominikschulz
Copy link
Member

I'm afraid, but I don't use this myself and don't have a lot of time right now.
This will need some help.

@dominikschulz dominikschulz pinned this issue Mar 6, 2023
@dominikschulz dominikschulz added the bug Something isn't working label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants