Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonapi to support edit #1

Open
rounakdatta opened this issue Oct 30, 2020 · 2 comments
Open

jsonapi to support edit #1

rounakdatta opened this issue Oct 30, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rounakdatta
Copy link

Summary

Today gopass-jsonapi does not support the API to edit a password. Having that feature would definitely be useful.

Steps To Reproduce

https://github.com/gopasspw/gopass/blob/master/docs/jsonapi.md - the documentation clearly mentions which APIs are available, and edit is not a part of it.

Expected behavior

An API corresponding to edit

  • request
{
   "type": "edit",
   "login": "myusername",
   "password": "mynewpassword"
}
  • response
{
   "username": "myusername",
   "password": "mynewpassword"
}

Environment

  • OS: macOS Catalina
  • OS version: Darwin
  • gopass Version: 1.10.1
  • Installation method: source/brew

Additional context

Having this API as a part of the jsonapi would open up multiple other opportunities like feature of editing directly from the gopassbridge extension. Nice to have.

@Pharb
Copy link
Member

Pharb commented Nov 8, 2020

Sounds like a useful feature. 👍
We can discuss the implementation details in the PR.

For reference, this relates to: gopasspw/gopassbridge#178

@dominikschulz dominikschulz transferred this issue from gopasspw/gopass Jan 15, 2021
@Pharb Pharb added enhancement New feature or request help wanted Extra attention is needed labels Feb 13, 2021
@Swathi-L
Copy link

Swathi-L commented Apr 6, 2022

Hi All,
If no one is working on this enhancement, can I start working on this?

guillermodotn pushed a commit to guillermodotn/gopass-jsonapi that referenced this issue Oct 5, 2024
Add arc browser to the list of valid browsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants