Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL kernel feature checks may throw an error #778

Open
jbghoul opened this issue Sep 14, 2022 · 0 comments · May be fixed by #779
Open

WebGL kernel feature checks may throw an error #778

jbghoul opened this issue Sep 14, 2022 · 0 comments · May be fixed by #779

Comments

@jbghoul
Copy link

jbghoul commented Sep 14, 2022

A GIF or MEME to give some spice of the internet

What is wrong?

WebGL kernel feature checks may throw an error

Where does it happen?

In WebGLKernel.setupFeatureChecks when trying to check if WebGL 1 kernel is supported

How do we replicate the issue?

prerequisite:

  • global variable document must be undefined

  • OffscreenCanvas class should be define

  • offsetCanvas.getContext('webgl') should not be truthly

  • compute GPU.isWebGLSupported

  • then, offsetCanvas.getContext('experimental-webgl') will throw an error

In Chrome you can directly test this case in console:

image

How important is this (1-5)?

2

Expected behavior (i.e. solution)

WebGLKernel.setupFeatureChecks should return without throwing exception.

testCanvas.getContext('experimental-webgl') should not be called on OffscreenCanvas

Other Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant