Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the target name for a sample directory #18

Open
wolfs opened this issue Jul 9, 2018 · 0 comments
Open

Allow configuring the target name for a sample directory #18

wolfs opened this issue Jul 9, 2018 · 0 comments

Comments

@wolfs
Copy link
Member

wolfs commented Jul 9, 2018

After #6 is merged, there is still one use-case missing for replacing the Sample Rule in gradle/gradle: The Sample rule allows configuring testSampleDirName, the target directory name for the sample.

I tried removing that functionality in the gradle/gradle code base, but I ran into long path issues on Windows: gradle/gradle#5713.

So there should be a possibility to configure the target directory where a sample is copied to, either by specifying a fixed relative path to the target base dir or a target directory directly.

I think using a target directory supplied as a File would suffice. This field could then be wired in the method computeSampleDir.

@eriwen eriwen self-assigned this Aug 9, 2018
@eriwen eriwen removed their assignment Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants