Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detectLevelFromLogLine does not cover all cases #14428

Open
sofielanduyts opened this issue Oct 8, 2024 · 1 comment
Open

detectLevelFromLogLine does not cover all cases #14428

sofielanduyts opened this issue Oct 8, 2024 · 1 comment

Comments

@sofielanduyts
Copy link

sofielanduyts commented Oct 8, 2024

The func detectLevelFromLogLine is not fully complete. (loki/pkg/distibutor/distributor.go)
For example, log lines with WARN .... will not be handled as level warning.

Removing the colon would include all cases.

This creates inconsistency with grafana as well.
Image
Even though there is no detected_level, it does get the color orange.

@sofielanduyts sofielanduyts changed the title Detect level from log line does not cover all cases detectLevelFromLogLine does not cover all cases Oct 8, 2024
@camrossi
Copy link

camrossi commented Oct 8, 2024

Having a similar issue as well, where my level is called "cleared" that is probably not super standard either :)

I did mention it in #12645 as I am also wondering how to handle this in the "right" way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants