Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

too many terms for the same thing (memoryStore/tank/aggmetrics/ring buffer/...) #1381

Open
Dieterbe opened this issue Jul 5, 2019 · 0 comments
Milestone

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Jul 5, 2019

these all describe the same thing:

  • MemoryStore (in api server) (easily confused with store plugins)
  • Tank (in exported metrics and a couple places in the docs) (not very descriptive, hard to search for)
  • AggMetric(s): the name of the go implementation (reasonably clear what it may do (?) though not very clear what the implementation is)
  • cicular buffer:, in-memory [ring]buffer: in some code go comments, config files and docs (very tied to the specific implementation, but doesn't really explain the "what" going into the ring buffer)

i want to reduce the amount of terms. perhaps to 1 for the general highlevel concept and another for the implementation. maybe simply "ringbuffer" for the concept (e.g. in docs, in metrics, in api server,...) and we keep AggMetric(s) for the classes that are being.. ringbuffered.. ?

@Dieterbe Dieterbe added this to the v1.0 milestone Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant