Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics #3597

Open
ahladh opened this issue Dec 24, 2023 · 2 comments · May be fixed by #5085
Open

When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics #3597

ahladh opened this issue Dec 24, 2023 · 2 comments · May be fixed by #5085
Labels
bug Something isn't working part:metrics/logging Relate to metric exporting or logging

Comments

@ahladh
Copy link

ahladh commented Dec 24, 2023 •
edited
Loading

What went wrong?

What happened:

When the Oncall plugin metrics are enabled using the variable FEATURE_PROMETHEUS_EXPORTER_ENABLED the metrics can be scraped from prometheus using the path http://<oncall-serviceip/dns>:8080**/metrics/** and not using the path http://<oncall-serviceip/dns>:8080**/metrics**

Generally when we scrape metrics using Prometheus the default path to scrape metrics is done using /metrics path across the eco system.

image

What did you expect to happen:

When we scrape metrics from prometheus using /metrics/ path as per docs we are able to get the metrics. But I feel the slash at the end should not a compulsion which is even making user confusing while configuring.

Hope this is considered as in this ecosystem /metrics path should get the metrics without much efforts in customising the path.

How do we reproduce it?

  1. While Installting the Oncall Enable the /metrics/ path using FEATURE_PROMETHEUS_EXPORTER_ENABLED.

Grafana OnCall Version

v1.3.80

Product Area

Alert Flow & Configuration, Helm

Grafana OnCall Platform?

Kubernetes

User's Browser?

No response

Anything else to add?

No response
@ahladh ahladh added the bug Something isn't working label Dec 24, 2023
@ahladh ahladh changed the title When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics(which is a general preference when scraping metrics using prometheus) When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics (which is a general preference when scraping metrics using prometheus) Dec 24, 2023
@ahladh ahladh changed the title When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics (which is a general preference when scraping metrics using prometheus) When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics Dec 24, 2023
@immuslim
Copy link

immuslim commented Feb 27, 2024 •
edited
Loading

im using chart version 1.3.106 with this values.yaml

 oncall:
    exporter:
      enabled: true

and create service monitor to scrape path /metrics/ port 8080 its works

@paltaa
Copy link

paltaa commented Jun 3, 2024

just confirmed that in chart version 1.4.4 with helm chart values:

 oncall:
    exporter:
      enabled: true

metrics are exposed but only works with /metrics/ and not /metrics on port 8080.

bck01215 added a commit to bck01215/oncall that referenced this issue Sep 25, 2024
@bck01215
migrate metrics path to /metrics
c05421e 
This resolves grafana#3597
bck01215 added a commit to bck01215/oncall that referenced this issue Sep 25, 2024
@bck01215
migrate metrics path to /metrics
79ab355 
This resolves grafana#3597
bck01215 added a commit to bck01215/oncall that referenced this issue Sep 25, 2024
@bck01215
migrate metrics path to /metrics
f639545 
This resolves grafana#3597
@bck01215 bck01215 linked a pull request Sep 25, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working part:metrics/logging Relate to metric exporting or logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate metrics path to /metrics bck01215/oncall
5 participants
@paltaa @iskhakov @joeyorlando @ahladh @immuslim