Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update doc to reflect thread sampling logic required for tracing integration on #3482

Open
knylander-grafana opened this issue Aug 13, 2024 · 0 comments
Labels
dotnet good first issue Good for newcomers type/docs Improvements for doc docs. Used by Docs team for project management

Comments

@knylander-grafana
Copy link
Contributor

knylander-grafana commented Aug 13, 2024

Update the docs to include this:

Walltime profiling is required to have thread sampling logic changed with the tracing integration on. However, this information is not included in the docs.

In the docs, walltime profiling is only mentioned in the .NET SDK: https://grafana.com/docs/pyroscope/latest/configure-client/language-sdks/dotnet/#dynamic-control

The trace to profiles documentation is on this page: https://grafana.com/docs/pyroscope/latest/configure-client/trace-span-profiles/dotnet-span-profiles/

Tasks:

  • Verify the information is correct
  • Which config options are useful for this?
  • Provide an example in the config option for the tracing integration
@knylander-grafana knylander-grafana added type/docs Improvements for doc docs. Used by Docs team for project management good first issue Good for newcomers dotnet labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet good first issue Good for newcomers type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

No branches or pull requests

1 participant