Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update modal to be closable from within the modal #938

Closed
xelaint opened this issue Jun 9, 2020 · 1 comment
Closed

[FEAT] Update modal to be closable from within the modal #938

xelaint opened this issue Jun 9, 2020 · 1 comment
Assignees
Labels
feat a new feature, enhancement, or improvement p2 medium priority package: design @daffodil/design

Comments

@xelaint
Copy link
Member

xelaint commented Jun 9, 2020

💡 Feature request

Feature Name

Update modal to be closable from within the modal.

The Desired Behavior

The modal should be closable from within the modal (i.e. close icon button or text close button). Modal is currently only closable by clicking on the backdrop.

Your Use Case

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Jun 9, 2020
@xelaint xelaint added this to the v0.8.0 - The Design Package V2 milestone Jun 9, 2020
@xelaint xelaint assigned xelaint and unassigned damienwebdev Jul 12, 2023
@AnnieMi888 AnnieMi888 removed this from the v0.8.0 - The Design Package V2 milestone Dec 19, 2023
@AnnieMi888 AnnieMi888 added the p2 medium priority label Dec 19, 2023
@xelaint
Copy link
Member Author

xelaint commented Aug 12, 2024

Fixed by #2832

@xelaint xelaint closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement p2 medium priority package: design @daffodil/design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants