Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal speed signal is not updated in USBDevice. #125

Open
ronyrus opened this issue Jul 29, 2021 · 1 comment
Open

Internal speed signal is not updated in USBDevice. #125

ronyrus opened this issue Jul 29, 2021 · 1 comment
Labels

Comments

@ronyrus
Copy link

ronyrus commented Jul 29, 2021

7d7960e introduced externally visible speed signal in USBDevice.
self.speed = Signal(2)
and it's updated from the reset sequencer:
self.speed .eq(reset_sequencer.current_speed),

however, there is also an internal speed signal:
speed = Signal(2, reset=USBSpeed.FULL)
This signal is passed into logic blocks, but is not updated at all.
It stays in its reset value.

IIUC, it should also be assigned to reset_sequencer.current_speed.
I wonder though, do we need two different signals in this case?
Probably better to just use the self.speed everywhere.

@straithe straithe added the technical support request for technical support label Nov 4, 2021
@straithe straithe added bug and removed technical support request for technical support labels Nov 15, 2021
@straithe
Copy link
Member

Thank you for bringing this issue to our attention. I have talked with our development team and they have suggested I upgrade this issue to bug. I will leave this issue open until we have an updated solution to provide you.

@straithe straithe self-assigned this Nov 15, 2021
@straithe straithe removed their assignment Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants