Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove friction when adding a new film #67

Open
radiantly opened this issue Mar 7, 2019 · 1 comment
Open

Remove friction when adding a new film #67

radiantly opened this issue Mar 7, 2019 · 1 comment

Comments

@radiantly
Copy link
Contributor

With #63 we have automatic ratings, but this includes way more steps required to go through when you add a new movie.

My 2 cents:

  • Generate storage.js from _prebuilt.md - The user is going to add the IMDb link when adding a movie. We could simply parse the file and add this into storage.js
  • Make Contributing.md more understandable. I had to hunt for _prebuilt.md
  • Then run npm run build-movies -> This is assuming that whoever is adding the movie knows how to use npm to install dependencies. Correct me if I'm wrong, but the user needs a local api-key?
  • Use something like Travis CI to build instead. I'm thinking of a pipeline like this: User modifies prebuilt.md and sends PR > Accept PR > CI automatically generates storage.js from _prebuilt.md. Then it runs npm build-movies and deploys it back to branch.
@greybax
Copy link
Owner

greybax commented Mar 7, 2019

Generate storage.js from _prebuilt.md - The user is going to add the IMDb link when adding a movie. We could simply parse the file and add this into storage.js

yes, this could be a better solution than we have now. Don't forget PRs are always welcome! ;)

Make Contributing.md more understandable. I had to hunt for _prebuilt.md

Will think about how to improve it. Thanks for comment

Then run npm run build-movies -> This is assuming that whoever is adding the movie knows how to use npm to install dependencies. Correct me if I'm wrong, but the user needs a local api-key?

If you want to run npm locally, so yes you need api key.

Use something like Travis CI to build instead. I'm thinking of a pipeline like this: User modifies prebuilt.md and sends PR > Accept PR > CI automatically generates storage.js from _prebuilt.md. Then it runs npm build-movies and deploys it back to branch.

Actually it almost how it works now. But we use Codeship instead of Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants