Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antioch tests aren't getting disabled when Antioch is #410

Closed
roystgnr opened this issue May 31, 2016 · 6 comments
Closed

Antioch tests aren't getting disabled when Antioch is #410

roystgnr opened this issue May 31, 2016 · 6 comments

Comments

@roystgnr
Copy link
Member

So "make check" is getting a host of failures, not just skips

@roystgnr
Copy link
Member Author

We're also now incompatible with the newest Antioch master, thanks to my mistake - when Antioch is built with MetaPhysicL, it then depends on metaphysicl/compare_types.h, but we don't have any antioch_config function and so there's no way for us to automatically pass on the header directories for that dependency. Not sure what the best fix is.

@pbauman
Copy link
Member

pbauman commented May 31, 2016

Thanks for reporting this. Obviously, I so rarely build without Antioch this crept in. I'll fix it this morning.

We're also now incompatible with the newest Antioch master, thanks to my mistake - when Antioch is built with MetaPhysicL, it then depends on metaphysicl/compare_types.h, but we don't have any antioch_config function and so there's no way for us to automatically pass on the header directories for that dependency. Not sure what the best fix is.

My knee-jerk reaction is to update the antioch.m4 in libantioch to include the relevant headers if Antioch is using MetaPhyscL. That way, the user shouldn't need to do anything (other than updating their antioch.m4 installation) since MetaPhyscL is header-only.

@nicholasmalaya
Copy link
Contributor

Getting a build with/without antioch regression on the newly revived buildbot would help catch this in the future. @roystgnr I don't see any reason we could not host GRINS at our Texas buildbot, unless @pbauman disagreed.

Just a thought.

@pbauman
Copy link
Member

pbauman commented May 31, 2016

I'd be thrilled to have you guys running this on your BuildBot server. I have my server, I'm just awaiting Civet being publicly released. @permcody any news on that?

@pbauman
Copy link
Member

pbauman commented May 31, 2016

Took care of this in 0dd005a in #408; thus it will be in the 0.7.0 release. Going ahead and closing this.

I've opened libantioch/antioch#205 to discuss the Antioch+MetaPhyscL issue.

@pbauman pbauman closed this as completed May 31, 2016
pbauman added a commit to pbauman/grins that referenced this issue May 31, 2016
@permcody
Copy link

I'll check on it. I haven't asked anyone for the last two weeks. It's got to be imminent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants