From 9a21be7026dc65ab4e98f0beb16fad0f4a8701c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Cutzach?= <gregoire@cutzach.com>
Date: Thu, 29 Aug 2024 12:11:44 +0200
Subject: [PATCH] fix: after lsebille review

---
 app/client/ui/AdminPanelCss.ts    | 6 +++---
 app/client/ui/DocumentSettings.ts | 7 ++++---
 app/client/ui2018/checkbox.ts     | 4 ++--
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/app/client/ui/AdminPanelCss.ts b/app/client/ui/AdminPanelCss.ts
index d0d48e8bc8..8f206467ec 100644
--- a/app/client/ui/AdminPanelCss.ts
+++ b/app/client/ui/AdminPanelCss.ts
@@ -106,7 +106,7 @@ const cssItem = styled('div', `
 
 const cssItemShort = styled('div', `
   display: flex;
-  flex-wrap: wrap;
+  flex-wrap: nowrap;
   align-items: center;
   padding: 8px;
   margin: 0 -8px;
@@ -131,7 +131,7 @@ const cssItemShort = styled('div', `
 `);
 
 const cssItemName = styled('div', `
-  width: 150px;
+  width: 230px;
   font-weight: bold;
   display: flex;
   align-items: center;
@@ -159,7 +159,7 @@ const cssItemName = styled('div', `
 `);
 
 const cssItemDescription = styled('div', `
-  max-width: 320px;
+  max-width: 250px;
   margin-right: auto;
   margin-bottom: -1px; /* aligns with the value */
 `);
diff --git a/app/client/ui/DocumentSettings.ts b/app/client/ui/DocumentSettings.ts
index 10f443a01f..302114ca3e 100644
--- a/app/client/ui/DocumentSettings.ts
+++ b/app/client/ui/DocumentSettings.ts
@@ -350,7 +350,7 @@ export class DocSettingsPage extends Disposable {
               dom('strong', t('Regular document')),
             ),
             dom('div',
-              dom.style('margin-top', '16px'),
+              dom.style('margin-top', '8px'),
               dom('span', t('Regular document behavior, all users work on the same copy of the document.'))
             ),
             testId('doctype-modal-option-regular'),
@@ -360,7 +360,7 @@ export class DocSettingsPage extends Disposable {
               dom('strong', t('Template')),
             ),
             dom('div',
-              dom.style('margin-top', '16px'),
+              dom.style('margin-top', '8px'),
               dom('span',
                 t('Document automatically opens in {{fiddleModeDocUrl}}. ' +
                   'Any edit (open to anybody) will create a new unsaved copy.',
@@ -377,7 +377,7 @@ export class DocSettingsPage extends Disposable {
               dom('strong', t('Tutorial')),
             ),
             dom('div',
-              dom.style('margin-top', '16px'),
+              dom.style('margin-top', '8px'),
               dom('span', t('Document automatically opens with a new copy.')),
             ),
             testId('doctype-modal-option-tutorial'),
@@ -678,6 +678,7 @@ const cssAdminSection = styled(AdminSection, `
 const cssDocTypeContainer = styled('div', `
   display: flex;
   width: 172px;
+  align-items: center;
   justify-content: space-between;
   & > * {
     display: inline-block;
diff --git a/app/client/ui2018/checkbox.ts b/app/client/ui2018/checkbox.ts
index 6926d4da49..30c30db8e0 100644
--- a/app/client/ui2018/checkbox.ts
+++ b/app/client/ui2018/checkbox.ts
@@ -108,7 +108,7 @@ export const cssCheckboxCircle = styled(cssCheckboxSquare, `
 `);
 
 export const cssLabelText = styled('span', `
-  margin-left: 8px;
+  margin-left: 16px;
   color: ${theme.text};
   font-weight: initial;   /* negate bootstrap */
   overflow: hidden;
@@ -215,7 +215,7 @@ export function toggle(value: Observable<boolean|null>, ...domArgs: DomElementAr
 // checkbox doesn't support two-way binding.
 const cssBlockCheckbox = styled('div', `
   display: flex;
-  padding: 10px 8px;
+  padding: 16px;
   border: 1px solid ${theme.controlSecondaryDisabledFg};
   border-radius: 3px;
   cursor: pointer;