Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document Settings UI for storage options for attachments #1341

Open
dsagal opened this issue Dec 12, 2024 · 2 comments
Open

Implement Document Settings UI for storage options for attachments #1341

dsagal opened this issue Dec 12, 2024 · 2 comments
Labels

Comments

@dsagal
Copy link
Member

dsagal commented Dec 12, 2024

The externalized attachments project (design doc here) allows each document to select whether attachments are stored internally in the doc, or in a preconfigured external storage.

The switch would be done in two steps:

  1. Set the desired destination/storage for attachments; new attachments will get stored there (just two options for now, "internal" and "external").
  2. Start the transfer of existing attachments to the selected destination. This may take some time.

Because of the two-step process and the fact that the transfer may take time, the current storage could be "internal", "external", or "mixed".

@dsagal dsagal converted this from a draft issue Dec 12, 2024
@lusebille
Copy link
Collaborator

lusebille commented Dec 16, 2024

Mocks are here (upper part of the board) https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/%5B05%2F24%5D-Grist-Design?node-id=3600-82240&t=kFXwKO4RsotbUKLw-1

@lusebille lusebille moved this from Todo to In Progress in Grist UI/UX Dec 16, 2024
@lusebille lusebille moved this from In Progress to To Review in Grist UI/UX Dec 18, 2024
@lusebille lusebille moved this from To Review to Ready to Dev in Grist UI/UX Dec 19, 2024
@dsagal
Copy link
Member Author

dsagal commented Dec 19, 2024

There is a new design (apologies for the late change): https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/%5B05%2F24%5D-Grist-Design?node-id=3600-82240&t=PYGb5S1L0MQJm1qz-0. I think it's better, because in the common case the user will just see a single clear setting.

The exact text needs review. I'll leave some comments in Figma, and @Spoffy perhaps you can review too, so that it matches how we are planning to talk about this feature elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to Dev
Development

No branches or pull requests

2 participants