Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ArticleDesign.PrintShop #12256

Closed
JamieB-gu opened this issue Aug 30, 2024 · 1 comment
Closed

Remove ArticleDesign.PrintShop #12256

JamieB-gu opened this issue Aug 30, 2024 · 1 comment
Assignees
Milestone

Comments

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Aug 30, 2024

This was introduced as a custom design in an attempt to handle the special cases where some print shop pieces1 were made immersive without a main media. However, we have decided that this should no longer be handled as a special case. Print shop pieces should work like other articles:

  1. If they have a main media they can be either showcase or immersive.
  2. If they do not have a main media they should not be set to immersive.

Examples

Footnotes

  1. https://www.theguardian.com/artanddesign/series/guardian-print-shop

@JamieB-gu JamieB-gu added this to the Health milestone Aug 30, 2024
@paperboyo
Copy link
Contributor

paperboyo commented Aug 31, 2024

Just to pt. 2

If they do not have a main media they should not be set to immersive.

“Should not” won’t ever result in “won’t”. And, to be honest, it seems to stem purely from DCR’s inability to deal with that scenario. Full scenario being not even just the lack of Main media in an Immersive piece, but the fact that the very first thing in a body is an image in an Immersive role (example) too.

In the spirit of this comment and Gareth’s

We should support lack of main media

Main media is not mandatory, never was. Any article, including those with Immersive Display Hint, can lack Main media alright.

FWIW, I never understood why DCR (unlike frontend; although both still struggle with furniture area) had problems with a combination of Immersive sans Main media and first body image set to Immersive. (Hats off to users who discovered this combo, as much as it complicates support, not their fault they were given the choice.) I always felt inventing a new format for a series is not a good idea. Ideally, platforms could just support whatever is legal. But I do recognise the practicalities… and with CP’s direction/advice, this series may not be the main “offender” any more. But the point of principle stands: both old and new pieces will continue to be able to use whatever is legal and if there is no support, it will look broken. However rarely.

In short: this (Immersive sans Main media [+1st body image immersified]) is not a hack at its core. It’s only a hack (and, as all hacks, flaky and liable to breakage), because DCR decided to deal with it in… a hacky way. I am first to admit I don’t understand how complex it might have been to ensure proper support.

So, I am ecstatic to see this format die! It was always a weirdo . Making exceptions and providing support for odd series isn’t ever a good idea and it will come back to bite us. But the model still allows for flexibility which, ideally, should be dealt with in a generic manner.

@JamieB-gu JamieB-gu added the Epic label Sep 2, 2024
@JamieB-gu JamieB-gu self-assigned this Sep 2, 2024
@jamesmockett jamesmockett removed their assignment Oct 8, 2024
@JamieB-gu JamieB-gu removed the Epic label Oct 16, 2024
@shesah shesah closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants