Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mypy errors from python examples #2047

Open
mturoci opened this issue Jun 28, 2023 · 13 comments · May be fixed by #2171
Open

Remove mypy errors from python examples #2047

mturoci opened this issue Jun 28, 2023 · 13 comments · May be fixed by #2171
Labels
chore Chores good first issue Contributions welcome! py Related to Python Driver

Comments

@mturoci
Copy link
Collaborator

mturoci commented Jun 28, 2023

  • Either install Mypy CLI or extension in your IDE of choice.
  • Run mypy against all py/examples files.
  • Refactor where needed, make sure the existing functionality is not broken.
@mturoci mturoci added py Related to Python Driver chore Chores labels Jun 28, 2023
@mturoci mturoci added the good first issue Contributions welcome! label Jul 6, 2023
@ng169
Copy link

ng169 commented Jul 6, 2023

i would like to work on this

@mturoci
Copy link
Collaborator Author

mturoci commented Jul 6, 2023

Go ahead :)

@raghav24agarwal
Copy link

Hi @mturoci , we have to fix all those codes based on Mypy CLI static code analyzer, is it?
Also, @ng169 , are you working on this ?

@mturoci
Copy link
Collaborator Author

mturoci commented Jul 31, 2023

we have to fix all those codes based on Mypy CLI static code analyzer, is it?

Correct.

@Swaggermuffin64
Copy link

is this finished? In that case can I work on this?

@mturoci
Copy link
Collaborator Author

mturoci commented Aug 14, 2023

It's still open and no PR was provided so anyone is free to work on this.

@laneo1986
Copy link

Hi I have just started going through this issue, hope that is ok. just pushed a correction with background_progress.py if there is any issues with my process, let me know thanks.

@mturoci
Copy link
Collaborator Author

mturoci commented Aug 30, 2023

Thanks @laneo1986 we can go over your changes during PR code review. Thanks for taking the contribution initiative! :)

@HarshitKmr10
Copy link

@laneo1986 are you still working on it or can I take it forward?

@7460m 7460m linked a pull request Oct 22, 2023 that will close this issue
5 tasks
@7460m
Copy link

7460m commented Oct 22, 2023

Hi @mturoci,

I'm a beginner to open source. I've read thought the [contributing guide] https://github.com/h2oai/wave/blob/main/.github/CONTRIBUTING.md) and set up my environment accordingly .

I have notice this issue is still open and the resent branch is been closed, so I went on to fixed the issue with my understanding of your project.

Total of 218 error has been fixed, some of the [import-untyped] error is due to the modules doesn't provided type stubs or a py.typed marker. I hope this helps :)

#2171

7460m added a commit to 7460m/wave that referenced this issue Oct 25, 2023
7460m added a commit to 7460m/wave that referenced this issue Oct 28, 2023
@Devanshusisodiya
Copy link

@mturoci has this issue been closed? As I was able to follow the conversation #2171 it doesn't seem like it.

@laneo1986
Copy link

laneo1986 commented Feb 5, 2024 via email

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 5, 2024

Hey @Devanshusisodiya. This is almost complete. I just need to brush up some final details that I didn't have much time for lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores good first issue Contributions welcome! py Related to Python Driver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants