-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mypy errors from python examples #2047
Comments
i would like to work on this |
Go ahead :) |
Correct. |
is this finished? In that case can I work on this? |
It's still open and no PR was provided so anyone is free to work on this. |
Hi I have just started going through this issue, hope that is ok. just pushed a correction with background_progress.py if there is any issues with my process, let me know thanks. |
Thanks @laneo1986 we can go over your changes during PR code review. Thanks for taking the contribution initiative! :) |
@laneo1986 are you still working on it or can I take it forward? |
Hi @mturoci, I'm a beginner to open source. I've read thought the [contributing guide] https://github.com/h2oai/wave/blob/main/.github/CONTRIBUTING.md) and set up my environment accordingly . I have notice this issue is still open and the resent branch is been closed, so I went on to fixed the issue with my understanding of your project. Total of 218 error has been fixed, some of the [import-untyped] error is due to the modules doesn't provided type stubs or a py.typed marker. I hope this helps :) |
I am no longer working k this was told it would be sorted. Apologies
Regards
Paul
…On Mon, 5 Feb 2024, 10:52 Devanshu Kumar Singh, ***@***.***> wrote:
@mturoci <https://github.com/mturoci> has this issue been closed? As I
was able to follow the conversation #2171
<#2171> it doesn't seem like it.
—
Reply to this email directly, view it on GitHub
<#2047 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZLEBD46NNGGPUDWYWDX5TYSC2X5AVCNFSM6AAAAAAZWWZJWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWG4YDOMZUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey @Devanshusisodiya. This is almost complete. I just need to brush up some final details that I didn't have much time for lately. |
py/examples
files.The text was updated successfully, but these errors were encountered: