-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display active table filter count #1689
Display active table filter count #1689
Comments
Hi me and other friends would like to take on this issue. |
Go ahead @jding712! |
The issue is up for grabs again for anyone interested. |
Thanks for your interest @Stijn-Kuijper!
Looking at the Fluent API, it seems like
Although this is an option, it may not be the optimal UX we are striving for as it would require an additional hover to show the counts. |
Hi, thanks for the quick reply!
Additionally, using |
Not sure I understood this fully. Are you saying this doesn't replace things like sorting/filter icons as well, but just the text? If so, the proper solution would be to render both sort/filter within the custom renderFunction. In fact, this would also make the
This should be achievable by absolute positioning relative to the filter chevron. |
This seems to be the case. Making changes in the
Does this mean the label, chevron and active filter count should all be rendered within the |
That's exactly what I think. Feel free to reach out if other assistance is needed. Btw, we also have Discord that may be better for such-realtime discussions. |
In that case I will have a look the coming days to see if I can come up with a fix. If I run into any more issues I'll make sure to run it by the discord first. Thanks for the help! |
Hello!! Is this issue still open. If yes me and my group would like to work on it? |
Yes, it's open. Feel free to make a PR :) |
Something like that yes, but ideally following the design outlined in the description. Non need to also add the selection count within context menu. |
maybe it would already be sufficient to change the open downward triangle to a filled downward triangle? |
Hello Wave, I have a solution for this change request to display a filter count on tables. As requested in the ticket, I have updated the table component so that it will display a count of selected options just to the top right of the chevron down icon. As suggested, I used And here is a short video demonstrating the filtering after this change: issue1689_ui-test.movI added 3 new unit tests to Question for you: The count is being rendered in red with a red border to match how the requirement is defined in the ticket. I wasn't sure if that was done in red make it stand-out in the screen shot or if this is how it was supposed to be implemented. Can you confirm if red text with red border is what you expect? I have a branch in my fork of the project and will be submitting a PR once I hear back about the styling of the new filter count. Let me know if this looks ok. Thanks! |
Hi, |
…esign, applied refactor suggestions, split select-deselect test cases and added reset test h2oai#1689
via @shihan007
The table currently supports filtering, but to see how many filters are active per column, one needs to click it and see which filter options are checked.
Instead, we could display the filter count in the top right corner relative to the chevron icon so that it's visible without clicking the chevron.
Implementation note: If there are > 9 filters active, display 9+ instead of the actual number to prevent too big count numbers and related spacing problems.
The text was updated successfully, but these errors were encountered: