Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tabs widget uses same entity property of a list for the label of a tab and the "add entity" button text #1

Open
e-me opened this issue Sep 17, 2021 · 1 comment

Comments

@e-me
Copy link

e-me commented Sep 17, 2021

Hello, we've came across a translation issue with languages that have cases (i.e. Greek).

Description:
The vertical tabs widget uses the entity property of a list for both - the label of a tab (https://github.com/h5p/h5p-editor-vertical-tabs/blob/master/vertical-tabs.js#L283) and for the "add entity" button text (https://github.com/h5p/h5p-editor-vertical-tabs/blob/master/vertical-tabs.js#L32) and that this may cause issues with Grammar in different languages as one of them has to be nominative and the latter one genitive.

Possible solution
A separate field for a list might be useful, could also be a separate field for the vertical tabs widget parameters if it won't get purged by the h5p cli tool, etc.

@e-me
Copy link
Author

e-me commented Oct 18, 2021

Any inputs on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant