Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.5 compatibility - install failure #562

Open
aspark21 opened this issue Sep 3, 2024 · 4 comments
Open

4.5 compatibility - install failure #562

aspark21 opened this issue Sep 3, 2024 · 4 comments

Comments

@aspark21
Copy link

aspark21 commented Sep 3, 2024 

    !!! Exception - Undefined constant "MESSAGE_DEFAULT_LOGGEDIN" !!!
    !!
    Error code: generalexceptionmessage !!
    !! Stack trace: * line 37 of /mod/hvp/db/messages.php: Error thrown
    * line 692 of /lib/messagelib.php: call to require()
    * line 419 of /lib/messagelib.php: call to message_get_providers_from_file()
    * line 617 of /lib/upgradelib.php: call to message_update_providers()
    * line 891 of /lib/upgradelib.php: call to upgrade_component_updated()
    * line 645 of /lib/upgradelib.php: call to upgrade_plugins_modules()
    * line 1931 of /lib/upgradelib.php: call to upgrade_plugins()
    * line 494 of /lib/installlib.php: call to upgrade_noncore()
    * line 492 of /lib/phpunit/classes/util.php: call to install_cli_database()
    * line 152 of /admin/tool/phpunit/cli/util.php: call to phpunit_util::install_site()
@aspark21 aspark21 mentioned this issue Sep 3, 2024
Open
@otacke
Copy link
Contributor

otacke commented Sep 3, 2024 •
edited
Loading

For reference: Deprecated since version 4.0 of moodle:
https://github.com/moodle/moodle/blob/13c12756b4d7e85f2d2e34038216179fd287c9c2/lib/upgrade.txt#L716 and final deprecation is about to be immanent with version 4.5 to be released on 7 October 2024. Cmp. https://tracker.moodle.org/browse/MDL-73284

@lkcivan
Copy link

lkcivan commented Sep 26, 2024

MESSAGE_DEFAULT_LOGGEDIN and MESSAGE_DEFAULT_LOGGEDOFF are now deprecated, so plugins should be updated if db/messages.php is present and replace
MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF to MESSAGE_DEFAULT_ENABLED.

jmmeijer added a commit to jmmeijer/moodle-mod_hvp that referenced this issue Oct 7, 2024
@jmmeijer
Update messages.php resolves h5p#562
dbfeb1c 
Resolves 4.5 compatibility - install failure h5p#562
Replaced MESSAGE_DEFAULT_LOGGEDIN + MESSAGE_DEFAULT_LOGGEDOFF to MESSAGE_DEFAULT_ENABLED as per Moodle plugin upgrade documentation: https://github.com/moodle/moodle/blob/13c12756b4d7e85f2d2e34038216179fd287c9c2/lib/upgrade.txt#L716

Thanks @otacke and @lkcivan
@jmmeijer jmmeijer mentioned this issue Oct 7, 2024
Open
@jmmeijer
Copy link

jmmeijer commented Oct 7, 2024

Just got the same errors when installing 1.27 on Moodle 4.5.
I've created a PR, hopefully it'll get resolved soon: #566

@bmackenty
Copy link

This is a show stopper for an upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jmmeijer @aspark21 @lkcivan @bmackenty @otacke