Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_mode misspelled overide #19

Open
artmg opened this issue Jan 18, 2020 · 2 comments
Open

run_mode misspelled overide #19

artmg opened this issue Jan 18, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@artmg
Copy link
Collaborator

artmg commented Jan 18, 2020

The value returned by the warmup climate entity when an override is set is misspelt.

overide

should have a double r as per all the object's property names and, er, the dictionary.

The value returned by the API appears to be an int, so to rectify this issue should be as simple as modifying the string value against the key in the dictionary declaration RUN_MODE = { at the start of warmup_cc/warmup4ie/warmup4ie.py. Therefore I'll leave this here for now in case anyone fancies having a crack at this as their first issue to PR and fix.

NB: for users this would be a Breaking Change, IF they rely on a text match with the mispelled text in the sensor template or automation logic, so we need to declare this on release

@artmg artmg added bug Something isn't working good first issue Good for newcomers labels Jan 18, 2020
@rct
Copy link
Collaborator

rct commented Feb 20, 2022

I don't know if it related to this typo/misspelling:

When the thermostat is set to override (boost) outside of Home Assistant, it does not show the mode change correctly in Home Assistant. For me the mode changes to auto during override and back to heat when the override is complete.

@artmg
Copy link
Collaborator Author

artmg commented Feb 23, 2022

@rct if you have this good, definitive test case, would you consider forking the project and making the change suggested in the first post above? If that fixes it then we can PR your change into the main project. Any contributions are very welcome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants