-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Min/Max temperature, can't set temperature through Home Assistant to anything reasonable. #38
Comments
as far as I can see, this warmup component assumes the thermostats themselves are reporting CELCIUS. It's hard coded. Not sure if we can read out that setting through the api, but willing to take a look. Can you confirm that your thermostat itself is set to Celsius? If Fahrenheit, can you try changing that and see if the conversion is done right in HA? |
Hi @rct the temperature conversion in this custom component was somewhat limited, and only applied to min and max temperatures. For other reasons #42, this conversion has now been removed #46, so either:
Please try out the component version now available on the latest master branch, and let us know. In the future we hope to have temperature conversion working #48, but for now we hope you are keeping warm |
I somehow never saw the replies in this issue. I'll give things a test. However, @kkoenen mentioned:
I'm in the US, the "Temperature Format" setting on each physical thermostat is set to "F". The Warmup web portal and iOS app seem to get this right, though the web portal does have some conversion problems in a few places, so I'll wind up with strange temperatures. |
Progress! I've got the current code running from the development So the fixes now show a correct Min/Max temperature in Fahrenheit.
So I believe the problem with the double conversion is fixed. Both before and after the fix, There are still however a number of temperature related attributes that are still in Celsius and aren't getting converted/localized (presumably by Home Assistant). Ideally these would get localized too. I suspect override, etc. wouldn't work without them. Maybe the types/units for them aren't being set correctly so that Home Assistant knows they are device class == temperature and unit of measurement is 'C'?
|
I can't use Home Assistant to set a reasonable temperature for a Warmup thermostat because of the
min_temp
andmax_temp
attributes in the climate entity.I'm in the US, so the unit system Home Assistant is using is Imperial (Fahrenheit). This may be related to #12 - temperature unit conversion
In Home Assistant the Min/Max temperature attributes show up as:
The lowest temperature I can set the thermostat to via Home Assistant is 86 F (30 C).
It could be that the temperature values were set in Fahrenheit and have been double converted to Celsius:
When I try to adjust the temperature through Home Assistant, It tries to set the temperature to 106 F (the minimum value) and then winds up setting to 86 F. (Some part of the system maybe enforcing the 86 F maximum and 86 F does make it through to the thermostat.)
The range of temperatures the Warmup Web Portal will let me set is 41 F to 86 F. So it seems plausible these values are already in Fahrenheit and are being converted from C to F incorrectly.
The text was updated successfully, but these errors were encountered: