-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename warmup_cc to warmup and then move this code into Home Assistant core. #4
Comments
On 1, I was expecting to do a bit more development work on this using the custom component arrangement, until it was good and stable. If however you are confident that we're ready to move it into a branch of the main HA fork, then we can go ahead and do that already |
First, thanks to everyone who has been contributing to this. I'd like to test and help if I can. However, at the moment, I'm not sure which repo/branch to start with and what the correct configuration is. Given that old warmup components are broken. My suggestions are:
|
Hi @rct thanks for offering to help out here - I have updated the master/README of this repo ( https://github.com/ha-warmup/warmup ) to clarify this is the one users should clone to test and run. I have also updated the instructions for configuration.yaml Hopefully once we have the component in the main HA tree then their release team would inform devs in advance of breaking changes affecting integrations, and if there are several people with access to update the code, we should not get stuck when someone is busy with real life |
Many thanks for the PR, @rct @foxy82 please take a look at what I wrote on the python library and let me know your views |
as @alex-0103 mentioned in [ha-warmup#4 Dec 2019](alex-0103#4 (comment)) he was too busy, this README ONLY change mentions what was broken by core and gives a link to a forked project where issues have been fixed.
The development approach for this component has settled on:
There is not currently enough development around this component to try and keep up with a fast-moving project like Home Assistant Code, but there should be enough interest in keeping the Home Assistant Community Store integration supported. Please see CONTRIBUTING.md and the documentation wiki for more. |
We need to split into 2 parts.
The text was updated successfully, but these errors were encountered: