Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/link to spark functions #138

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Doc/link to spark functions #138

merged 2 commits into from
Jan 24, 2022

Conversation

eruizalo
Copy link
Collaborator

No description provided.

@eruizalo eruizalo added the documentation Improvements or additions to documentation label Jan 10, 2022
@eruizalo eruizalo self-assigned this Jan 10, 2022
@eruizalo eruizalo linked an issue Jan 10, 2022 that may be closed by this pull request
Fix complex scaladoc links #135
Open
@eruizalo eruizalo mentioned this pull request Jan 10, 2022
Open
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #138 (7d59780) into main (ccd80c8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   94.84%   94.84%   -0.01%     
==========================================
  Files          41       41              
  Lines         698      697       -1     
  Branches        9       11       +2     
==========================================
- Hits          662      661       -1     
  Misses         36       36
Impacted Files Coverage Δ
...re/src/main/scala/doric/syntax/BinaryColumns.scala 100.00% <ø> (ø)
...e/src/main/scala/doric/syntax/BooleanColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/CommonColumns.scala 94.12% <ø> (ø)
core/src/main/scala/doric/syntax/DateColumns.scala 100.00% <ø> (ø)
...src/main/scala/doric/syntax/TimestampColumns.scala 80.00% <ø> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd80c8...7d59780. Read the comment docs.

@eruizalo
Copy link
Collaborator Author

Some issues found trying to document (via link) these functions:

  • org.apache.spark.sql.functions.locate
  • org.apache.spark.sql.functions.split
  • org.apache.spark.sql.functions.to_utc_timestamp
  • org.apache.spark.sql.functions.from_utc_timestamp

Related to issue #135

@eruizalo eruizalo merged commit b5efcd4 into hablapps:main Jan 24, 2022
@eruizalo eruizalo deleted the doc/link_to_spark_functions branch January 24, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsorr alfonsorr alfonsorr approved these changes

Assignees

@eruizalo eruizalo

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix complex scaladoc links
2 participants
@eruizalo @alfonsorr