Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

144 - no error handling for failure to create new donor #144

Open
esauerbo opened this issue Feb 9, 2023 · 0 comments
Open

144 - no error handling for failure to create new donor #144

esauerbo opened this issue Feb 9, 2023 · 0 comments
Labels
bug Something isn't working frontend

Comments

@esauerbo
Copy link
Collaborator

esauerbo commented Feb 9, 2023

Describe the bug
Currently if the request to api/location/addDonors fails, the frontend will still indicate success. This is because the call to dispatchCreateNew in DonorsForm does not check the return code after creating a new donor.

To Reproduce
Introduce some sort of network error while making the request, or modify the frontend so an incorrect object is returned.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@esauerbo esauerbo added bug Something isn't working frontend labels Feb 9, 2023
@esauerbo esauerbo changed the title 143 - no error handling for failure to create new donor 144 - no error handling for failure to create new donor Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

1 participant