Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to add unique links and remove existing ones on the live site #2

Open
yousefa00 opened this issue May 20, 2021 · 6 comments
Assignees

Comments

@yousefa00
Copy link

yousefa00 commented May 20, 2021

Rather than submitting new commits for every new shortened link, admins should be able to sign-in at h4i.app and add/remove forwards.

@arpanlaha
Copy link
Member

arpanlaha commented May 30, 2021

IMO this requires too much work to be worth it, as we'd need a full stack app with auth and a database - I don't think the benefit outweighs the development time cost, and its not a very interesting technical problem either in my eyes (I wouldn't want to spend time writing it out as I don't find it compelling engineering work).

@yousefa00
Copy link
Author

Yeah, not sure why you were assigned for this. I'll work on it this summer, or have the infra team work on it. Will also be rewriting the backend completely in express and hooking into the memberDB tool's api to figure out which members are actually registered in our org (which i think is a pretty cool use for it).

@arpanlaha
Copy link
Member

arpanlaha commented May 30, 2021

Honestly I still don't think it's that worth it as we do have our own membership list through GitHub - I only see significant value in having this be someone's first full stack app as it sits in the weird spot of extremely simple business logic that still requires a full stack which is too much work for how simple it is. Up to you all ofc on final call though

@yousefa00
Copy link
Author

Appreciate the note, but making commits for every change is not the way I want this infra to work. I also don't think authentication and the backend are a lot of work, as it's nothing new from what we've done with memberDB tool, and think this would be a good project for the summer with its small scope.

@arpanlaha
Copy link
Member

If there are features I would want to see from a more complex version it would be link visibility - which shortcuts do we want put on the main page vs. which we don't (like an "unlisted" link)

@arpanlaha
Copy link
Member

Additionally maybe analytics of some sort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants