fold bitmaps right after update has been propagated in editor modal #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Also rename updateCulprit -> lastUpdater since 'culprit' has a negative connotation to it
JosiasAurel
force-pushed
the
fix/unfold-bitmaps-multiplayer
branch
from
461e0fe
to
bf69bdf
Compare
Cosmin-Mare
requested changes
Oct 2, 2024
|
Do we plan on this PR surviving and moving forward, or do we kill it with 🔥 ? |
|
Afaik @JosiasAurel is working on finding a way to only collapse the bitmap that has been edited, so no🔥yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2368
when a change is propagated to bitmaps/map/tune, their template literals get unfolded and the change applied. however, they're not closed back. this change forces the template literals to fold after these changes have been applied to the editor.