Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove workaround for ghc 9.6.2 spurious warning when we upgrade to ghc 9.6.3 #1152

Closed
brprice opened this issue Sep 28, 2023 · 1 comment · Fixed by #1162
Closed

chore: remove workaround for ghc 9.6.2 spurious warning when we upgrade to ghc 9.6.3 #1152

brprice opened this issue Sep 28, 2023 · 1 comment · Fixed by #1162
Assignees
@brprice
Labels
quick This issue can probably be fixed relatively quickly

Comments

@brprice
Copy link
Contributor

brprice commented Sep 28, 2023 •
edited
Loading

In #1113 we bumped to ghc 9.6.2 but discovered there was a bug with spurious warnings and deriving: https://gitlab.haskell.org/ghc/ghc/-/issues/23143. We added some pragmas {-# OPTIONS -Wno-redundant-constraints #-} (e.g.

primer/primer-api/src/Primer/API.hs

Line 10 in 091330c

{-# OPTIONS -Wno-redundant-constraints #-}
) to silence these. The issue is now fixed upstream, and released in ghc 9.6.3. When we upgrade ghc (note that haskell.nix does not yet support 9.6.3) we should remove these pragmas, so they do not quash other (valid) warnings. (We may also want to bump a minimum version bound to enforce ghc 9.6.3's use)
@brprice brprice added quick This issue can probably be fixed relatively quickly blocked/upstream ❌ Blocked by upstream issue labels Sep 28, 2023
@brprice brprice self-assigned this Sep 28, 2023
@georgefst
Copy link
Contributor

georgefst commented Sep 28, 2023 •
edited
Loading

We may also want to bump a minimum version bound to enforce ghc 9.6.3's use

I'd be inclined not to. As a library maintainer, I've found that being warning-free across versions tends to be more effort than it's worth (although it is a shame that "warnings" in GHC can be anything from totally harmless (e.g. missing signature) to essentially errors (incomplete patterns) - though this may improve soon: ghc-proposals/ghc-proposals#571).

@brprice brprice mentioned this issue Oct 9, 2023
Merged
@dhess dhess removed the blocked/upstream ❌ Blocked by upstream issue label Oct 9, 2023
@dhess dhess mentioned this issue Oct 9, 2023
Merged
dhess added a commit that referenced this issue Oct 9, 2023
@dhess
chore: remove GHC 9.6.2 spurious warning workarounds
b124dba 
We're now on GHC 9.6.3, so these should no longer be necessary on our
build.

Closes #1152

Signed-off-by: Drew Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brprice brprice

Labels
quick This issue can probably be fixed relatively quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove GHC 9.6.2 spurious warning workarounds hackworthltd/primer
3 participants
@dhess @brprice @georgefst