Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting & Testing #9

Merged
merged 11 commits into from
Jan 17, 2022
Merged

Linting & Testing #9

merged 11 commits into from
Jan 17, 2022

Conversation

baodrate
Copy link
Owner

@baodrate baodrate commented Jan 17, 2022

Copy configs from typeshed project
Add stubtest to github action
This commit fixes the issue pointed out in:
hahow/pika-stubs#9

Namely `int` and `float` not (statically) evaluating as subclasses of
their abstract types in `numbers`:
python/mypy#3186

These abstract types have been replaced with their concrete equivalent.
Note that this does not match the code in pika, which *does* compare
against e.g. `numbers.Integral` at runtime. But the documented API only
mentions concret types (i.e. `int` and `float`) so this is considered a
reasonable compromise.

addresses hahow/pika-stubs/issues/9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of numbers.* encounters a bug in mypy
1 participant