Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch commits into larger release #7

Open
nathanielc opened this issue Dec 6, 2018 · 0 comments
Open

Batch commits into larger release #7

nathanielc opened this issue Dec 6, 2018 · 0 comments

Comments

@nathanielc
Copy link

What is the intended workflow to batch releases with more that a single commit?

As I understand it the purpose of this bot is to determines the new semver tag and creates a new github release with that tag based on new commits to master.

As such a typical workflow of merging to master creates a new release for every commit. This creates lots of noise and make its hard to track what has changed beyond just reading the git log, thus defeating the purpose of the bot.

Is there an intended workflow to batch multiple commits into a single release?

I tried creating a develop branch and setting that branch as the github default. Then new PR and changes would land on the develop branch. Then to create a batched release I created a PR from develop to master. This correctly created a batch release as expected.

But there were a few edge cases that made this workflow not ideal.

  1. We use the Rebase+Merge strategy with Github, as such we want to disable the Merge commits option in Github. But the version diff for the change log generation will break unless we use a merge commit for the merge of develop to master. We can just do the merge commit locally and push it up to Github, but the bot does not seem to trigger on pushes to master that are not part of PRs, (Maybe this is a separate bug?)
  2. By changing the default branch to a develop branch in Github, Github thinks that all the Merge commits in the master branch need to be merged back into the develop branch and suggests merging master back into develop, which should not be necessary. This one can just be ignored if there is no real solution to it.

Both of these issues combined made me think that I was missing something obvious with how this bot was intended to be used. Any pointers on how to manage batched releases with this bot would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant