Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV Series titles with '!' are ignored #78

Open
woopla opened this issue Nov 27, 2022 · 4 comments
Open

TV Series titles with '!' are ignored #78

woopla opened this issue Nov 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@woopla
Copy link

woopla commented Nov 27, 2022

Describe the bug
Excludarr is not properly parsing environment variables that have the character ! in their values. There's no error message, but the whole variable is ignored (when specifying multiple TV series to exclude, all of them are non-ignored, just not the one with !).

To Reproduce
Steps to reproduce the behavior:

  1. docker run -it --rm --env-file excludarr.env haijeploeg/excludarr:latest sonarr exclude --action delete --progress
  2. TV Series is Call My Agent!
  3. Relevant line in my excludarr.env file:
SONARR_EXCLUDE='Cowboy Bebop, Call My Agent!'

Expected behavior
I would expect both Cowboy Bebop and Call My Agent! to be ignored.

Versions
I'm using the latest Docker tag as of 2022-11-26.

Debug logging
Running in debug mode shows the configuration that's created from the command-line + env. variables:

[2022-11-27 02:34:42] - Read the following configuration: {'general': {'fast_search': True, 'locale': 'en_US',
'providers': ['netflix']}, 'radarr': {'url': 'https://movies.XXXX.net', 'api_key': '<REDACTED>', 'verify_ssl': 
False, 'exclude': ['']}, 'sonarr': {'url': 'https://tvseries.XXXX.net', 'api_key': '<REDACTED>', 'verify_ssl': 
False, 'exclude': ['Cowboy Bebop, Call My Agent!']}}

Looking at the content of the exclude entry in the dictionary, it looks like the env. variable was not properly split.

@woopla woopla added the bug Something isn't working label Nov 27, 2022
@haijeploeg
Copy link
Owner

Hi,

That is strange, have you tried it with double quotes as well? SONARR_EXCLUDE="Cowboy Bebop, Call My Agent!". I am developing a new version with a UI right now, in this version the exclude list will be filled in a form, hence formatting it correctly by default.

Can you let me know if double quoting works?

@woopla
Copy link
Author

woopla commented Nov 28, 2022

My original trial was with double quotes actually. I tried single quotes to see if this was not an interaction with the shell's parsing of !, but it does not change anything. I also tried \!, no luck...

@haijeploeg
Copy link
Owner

Hmpf bummer, I am not fixing anything in version 1 of excludarr anymore. This will be fixed in version 2 of excludarr. I am hoping to release around the end of this year.

@woopla
Copy link
Author

woopla commented Nov 28, 2022

No worries I can wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants