Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

讨论：是否有必要在应用详情中提供评论功能 #11

Open
ruibaby opened this issue Sep 9, 2023 · 2 comments
Open

讨论：是否有必要在应用详情中提供评论功能 #11

ruibaby opened this issue Sep 9, 2023 · 2 comments

Comments

@ruibaby
Copy link
Member

ruibaby commented Sep 9, 2023

image

如图：虽然目前提供了评论的选项卡，但是还没有实现相关功能，只是为了和 Halo 官网的应用市场保持 UI 一致。

如果需要支持评论功能，有几个需要考虑的地方：

  1. 评论组件需要提供支持。
  2. 如何登录。
@ruibaby
Copy link
Member Author

ruibaby commented Sep 9, 2023

最主要的问题还是在于如何登录。

@ruibaby ruibaby mentioned this issue Sep 15, 2023
Merged
@JohnNiang
Copy link
Member

是否能支持仅显示评论，如果想要评论，则直接跳转至对应的应用页面，例如：https://halo.run/store/apps/app-dHakX?tab=comment。

f2c-ci-robot bot pushed a commit that referenced this issue Sep 15, 2023
@ruibaby
refactor: remove comment tab panel in app detail modal (#26)
1d2a6c3 
暂时移除应用详情页面的评论选项卡，讨论可见：#11

/kind improvement

```release-note
暂时移除应用详情页面的评论选项卡
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnNiang @ruibaby