Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in gradient updating #6

Open
bjourne opened this issue May 2, 2019 · 0 comments
Open

Bug in gradient updating #6

bjourne opened this issue May 2, 2019 · 0 comments

Comments

@bjourne
Copy link

bjourne commented May 2, 2019

Your article and sample code is very useful! But there is a bug in run_iter I think. Vectors are updated in the same loop that gradients are calculated in. I don't think that is correct? Instead, all gradients should be calculated in one loop and in a second loop all updates should be applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjourne