Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running a formatter and checker on python code #601

Open
oyvindln opened this issue Jan 8, 2021 · 2 comments
Open

Consider running a formatter and checker on python code #601

oyvindln opened this issue Jan 8, 2021 · 2 comments
Labels
enhancement ld-decode An issue only affecting the ld-decode[r]

Comments

@oyvindln
Copy link
Contributor

oyvindln commented Jan 8, 2021

Right now the code has a mix of spaces and tabs and not any consistent formatting, and when I load core.py in emacs flake8 gives up with too many errors.

I've used black for the vhs code but there are several other alternatives. A syntax checker like flake8 could also help clean up things, get rid of unused variables and maybe even uncover bugs.

Maybe also consider splitting up core.py as it's 3k lines.

@simoninns simoninns added enhancement ld-decode An issue only affecting the ld-decode[r] labels Jan 8, 2021
@happycube
Copy link
Owner

Thanks for the pointers... I've run black in the chad-2021.01.01 branch and handled a few flake8 complaints (and will probably gradually handle more)

Yeah, core.py should be split up. As part of the audio rework I'll put that into it's own file, and probably break out the threading bits as well. It's almost 4k lines now though after running through black...

@happycube
Copy link
Owner

Haven't found any bugs yet, but it seriously points out clunky expressions which I'll slowly deal with ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ld-decode An issue only affecting the ld-decode[r]
Projects
None yet
Development

No branches or pull requests

3 participants