Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBC off-by-one output error. #790

Open
happycube opened this issue Aug 29, 2022 · 1 comment
Open

TBC off-by-one output error. #790

happycube opened this issue Aug 29, 2022 · 1 comment
Assignees
Labels
ld-decode An issue only affecting the ld-decode[r]
Milestone

Comments

@happycube
Copy link
Owner

From #789, this is an off by one (or maybe even 0.5?) error I need to fix. I think the intention was to log the beginning of the line at 1/2*SYNC IRE, but it should be outputting once SYNC level is reached.

"(Note that the output is still offset to the right when compared with ld-decode's output for both PAL and NTSC - this is because it's following SMPTE 244M/EBU Tech 3280 by having each line contain all the blanking samples, then all the active samples, whereas ld-decode starts each line with the sample immediately before 0H.)"

@happycube happycube self-assigned this Aug 29, 2022
@happycube happycube added this to the Revision 8 milestone Aug 29, 2022
@atsampson
Copy link
Collaborator

I think it does behave as intended at the moment (the first sample on each line is the nearest sample immediately before 0H, halfway down the leading sync edge - you can't sample on 0H because it falls between two samples for both NTSC and 4fSC PAL).

This is related to #242 - ideally both NTSC and PAL would be sampled at 4fSC exactly, and the output would conform to the SMPTE/EBU standards in terms of the contents of each line and how the samples are phased relative to the subcarrier. The tools can handle output like this already.

@simoninns simoninns added the ld-decode An issue only affecting the ld-decode[r] label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ld-decode An issue only affecting the ld-decode[r]
Projects
None yet
Development

No branches or pull requests

3 participants